Fetch project owner on get #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 26, 2021 11:16
<
8000
div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo2MjE3NzMyNzpjb21taXQ6NTI3OTViNjE0ZjcyNDQ4OTJiODVjOGVjMWU3NzhiZTNhMTRhOWQzMyIsInQiOjE3NDg1MTUxODN9--6074ecd43deb363bccb08a9b4d42fb38db8d95d3985d277fdedd38173eb389d6" data-url="/tableau/server-client-python/pull/784/partials/commit_status_icon?oid=52795b614f7244892b85c8ec1e778be3a14a9d33">
|
I think grabbing owner and populating it is great, the NotImplemented exception is fine but I'm not a fan of the comments hanging out in the code. Would you be willing to nix the comments but keep the rest :) |
|
I can understand not liking the commented code there. I did it with the idea of referencing what needs to be enabled once the issue is resolved, but removed it. |
t8y8
suggested changes
Jan 27, 2021
|
Thanks @jorwoods! |
shinchris
pushed a commit
that referenced
this pull request
Feb 17, 2021
[Release] Sync master with v0.15 changes ## 0.15.0 (16 Feb 2021) * Added support for python version 3.9 (#744) * Added support for 'Get View by ID' (#750) * Added docs and test data to MANIFEST.in file (#780) * Added owner_id property to ProjectItem (#784) * Added support for skipping connection check while publishing workbook (#791) * Added support for 'Update Subscription' (#794) * Added support for 'Get Groups for a User' (#799) * Improved debug logging by including put/post request contents (#743) * Improved local and active-directory group creation (#770) * Improved 'Update Group' to match server requests/responses (#772) * Improved SiteItem with new properties and functions (#777) * Improved SubscriptionItem with new properties (#794) * Improved the 'type' property of TaskItem to convert server response to enum (#796) * Improved repository to use Github Actions for running tests/linter (#798) * Fixed data_acceleration field causing error in workbook update payload (#741)
shinchris
pushed a commit
that referenced
this pull request
Feb 17, 2021
[Release] Sync master with v0.15 changes * Added support for python version 3.9 (#744) * Added support for 'Get View by ID' (#750) * Added docs and test data to MANIFEST.in file (#780) * Added owner_id property to ProjectItem (#784) * Added support for skipping connection check while publishing workbook (#791) * Added support for 'Update Subscription' (#794) * Added support for 'Get Groups for a User' (#799) * Improved debug logging by including put/post request contents (#743) * Improved local and active-directory group creation (#770) * Improved 'Update Group' to match server requests/responses (#772) * Improved SiteItem with new properties and functions (#777) * Improved SubscriptionItem with new properties (#794) * Improved the 'type' property of TaskItem to convert server response to enum (#796) * Improved repository to use Github Actions for running tests/linter (#798) * Fixed data_acceleration field causing error in workbook update payload (#741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
owner_idtoProjectItemand populates it via theprojects.getendpoint. Adds stubs for updating owner via create/update calls, but leaves them commented out pending server-side enhancement. Raises aNotImplementedErrorwhen trying to setowner_idon aProjectItemas that is currently not supported server side.