10000 Fetch project owner on get by jorwoods · Pull Request #784 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Fetch project owner on get #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 1, 2021

Conversation

jorwoods
Copy link
Contributor
@jorwoods jorwoods commented Jan 26, 2021

Adds owner_id to ProjectItem and populates it via the projects.get endpoint. Adds stubs for updating owner via create/update calls, but leaves them commented out pending server-side enhancement. Raises a NotImplementedError when trying to set owner_id on a ProjectItem as that is currently not supported server side.

Jordan Woods added 4 commits January 26, 2021 11:16
< 8000 div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo2MjE3NzMyNzpjb21taXQ6NTI3OTViNjE0ZjcyNDQ4OTJiODVjOGVjMWU3NzhiZTNhMTRhOWQzMyIsInQiOjE3NDg1MTUxODN9--6074ecd43deb363bccb08a9b4d42fb38db8d95d3985d277fdedd38173eb389d6" data-url="/tableau/server-client-python/pull/784/partials/commit_status_icon?oid=52795b614f7244892b85c8ec1e778be3a14a9d33">
@t8y8
Copy link
Collaborator
t8y8 commented Jan 27, 2021

I think grabbing owner and populating it is great, the NotImplemented exception is fine but I'm not a fan of the comments hanging out in the code.

Would you be willing to nix the comments but keep the rest :)

@jorwoods
Copy link
Contributor Author

I can understand not liking the commented code there. I did it with the idea of referencing what needs to be enabled once the issue is resolved, but removed it.

Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t8y8 t8y8 merged commit f566c05 into tableau:development Feb 1, 2021
@shinchris
Copy link
Contributor

Thanks @jorwoods!

shinchris pushed a commit that referenced this pull request Feb 17, 2021
[Release] Sync master with v0.15 changes
## 0.15.0 (16 Feb 2021)
* Added support for python version 3.9 (#744)
* Added support for 'Get View by ID' (#750)
* Added docs and test data to MANIFEST.in file (#780)
* Added owner_id property to ProjectItem (#784)
* Added support for skipping connection check while publishing workbook (#791)
* Added support for 'Update Subscription' (#794)
* Added support for 'Get Groups for a User' (#799)
* Improved debug logging by including put/post request contents (#743)
* Improved local and active-directory group creation (#770)
* Improved 'Update Group' to match server requests/responses (#772)
* Improved SiteItem with new properties and functions (#777)
* Improved SubscriptionItem with new properties (#794)
* Improved the 'type' property of TaskItem to convert server response to enum (#796)
* Improved repository to use Github Actions for running tests/linter (#798)
* Fixed data_acceleration field causing error in workbook update payload (#741)
shinchris pushed a commit that referenced this pull request Feb 17, 2021
[Release] Sync master with v0.15 changes
* Added support for python version 3.9 (#744)
* Added support for 'Get View by ID' (#750)
* Added docs and test data to MANIFEST.in file (#780)
* Added owner_id property to ProjectItem (#784)
* Added support for skipping connection check while publishing workbook (#791)
* Added support for 'Update Subscription' (#794)
* Added support for 'Get Groups for a User' (#799)
* Improved debug logging by including put/post request contents (#743)
* Improved local and active-directory group creation (#770)
* Improved 'Update Group' to match server requests/responses (#772)
* Improved SiteItem with new properties and functions (#777)
* Improved SubscriptionItem with new properties (#794)
* Improved the 'type' property of TaskItem to convert server response to enum (#796)
* Improved repository to use Github Actions for running tests/linter (#798)
* Fixed data_acceleration field causing error in workbook update payload (#741)
@jorwoods jorwoods deleted the jorwoods/project_owners branch March 25, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0