-
Notifications
You must be signed in to change notification settings - Fork 436
Fetch project owner on get #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think grabbing owner and populating it is great, the NotImplemented exception is fine but I'm not a fan of the comments hanging out in the code. Would you be willing to nix the comments but keep the rest :) |
I can understand not liking the commented code there. I did it with the idea of referencing what needs to be enabled once the issue is resolved, but removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thanks @jorwoods! |
[Release] Sync master with v0.15 changes ## 0.15.0 (16 Feb 2021) * Added support for python version 3.9 (#744) * Added support for 'Get View by ID' (#750) * Added docs and test data to MANIFEST.in file (#780) * Added owner_id property to ProjectItem (#784) * Added support for skipping connection check while publishing workbook (#791) * Added support for 'Update Subscription' (#794) * Added support for 'Get Groups for a User' (#799) * Improved debug logging by including put/post request contents (#743) * Improved local and active-directory group creation (#770) * Improved 'Update Group' to match server requests/responses (#772) * Improved SiteItem with new properties and functions (#777) * Improved SubscriptionItem with new properties (#794) * Improved the 'type' property of TaskItem to convert server response to enum (#796) * Improved repository to use Github Actions for running tests/linter (#798) * Fixed data_acceleration field causing error in workbook update payload (#741)
[Release] Sync master with v0.15 changes * Added support for python version 3.9 (#744) * Added support for 'Get View by ID' (#750) * Added docs and test data to MANIFEST.in file (#780) * Added owner_id property to ProjectItem (#784) * Added support for skipping connection check while publishing workbook (#791) * Added support for 'Update Subscription' (#794) * Added support for 'Get Groups for a User' (#799) * Improved debug logging by including put/post request contents (#743) * Improved local and active-directory group creation (#770) * Improved 'Update Group' to match server requests/responses (#772) * Improved SiteItem with new properties and functions (#777) * Improved SubscriptionItem with new properties (#794) * Improved the 'type' property of TaskItem to convert server response to enum (#796) * Improved repository to use Github Actions for running tests/linter (#798) * Fixed data_acceleration field causing error in workbook update payload (#741)
Adds
owner_id
toProjectItem
and populates it via theprojects.get
endpoint. Adds stubs for updating owner via create/update calls, but leaves them commented out pending server-side enhancement. Raises aNotImplementedError
when trying to setowner_id
on aProjectItem
as that is currently not supported server side.