Minor fixes about bundle overridding #7490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2017 16:06
The old sentence was confusing. This one works better.
Its better to use e.g. here cause that is just an example. Doesn't always going to be in that path.
Closed
The word 'or' is clear. / not so much.
Titles use caps. Unnecessary sentence.
This does only apply to Symfony >= 3.0.
|
LGTM 👍 |
HeahDude
approved these changes
Feb 27, 2017
bundles/override.rst
Outdated
|
|
||
| $builder->add('name', new CustomType()); | ||
| Existing form types can be modified defining "form type extensions". | ||
| For more information, see :doc:`/form/create_form_type_extension`. |
xabbuh
reviewed
Feb 28, 2017
bundles/inheritance.rst
Outdated
| If you refer to resources without using the ``@BundleName`` shortcut, they | ||
| can't be overridden in this way. | ||
| You need to use the ``@BundleName`` shortcut when refering to resources | ||
| so they can be successfully overridden. |
There was a problem hiding this comment.
There has been confusion in the past about which resources we refer to here. I think we should make more clear that this note does not apply when we talk about templates as the overriding of them works no matter if you use the bundle syntax or the native Twig namespace syntax (I know that the syntax is not exactly the same as what we use to refer to other resources, but that's not so obvious).
wouterj
approved these changes
Mar 5, 2017
bundles/override.rst
Outdated
| rather than:: | ||
|
|
||
| $builder->add('name', new CustomType()); | ||
| Existing form types can be modified defining "form type extensions". |
There was a problem hiding this comment.
I propose: "form type extensions" -> *form type extensions*
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
…javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Minor fixes about bundle overridding This finishes #6985. Commits ------- c9a52ae Added the changes suggested by reviewers d5cd8d0 Reworded the section about form overridding 600d302 Update installation.rst 62bfc21 Update prepend_extension.rst 2f837d6 Update override.rst 3433e50 Update installation.rst f684bdd Update inheritance.rst
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
* 2.7: [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests Added the changes suggested by reviewers Fixed status code test Improved a test Merged and improved the articles about testing + authentication Reworded the section about form overridding Update installation.rst Update prepend_extension.rst Update override.rst Update installation.rst Update inheritance.rst Unify placeholders in documentation and code
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
* 2.8: (46 commits) [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests Added the changes suggested by reviewers [#7620] use generate() in PHP templates before 2.8 Fixed the RST syntax Improve example context [#5621] Enhancing example of using bundle config [#7601] minor tweak Update expiration.rst Update expiration.rst Update expiration.rst Update expiration.rst Minor reword and fixed the line 8000 length Improve specification explanation [#7664] minor wording tweak Rewords and minor fixes Add an explanation about «constraints» validation [#7645] enumerate ordered list items implicitly Adding a new article about "Creating a Bug Reproducer" ...
weaverryan
added a commit
that referenced
this pull request
Apr 15, 2017
* 3.2: (71 commits) Rewriting the service container docs Minor reword Adding a tip for validation in forms without class [#7217] add versionadded directives [#7203] merge note and versionadded directive Use the new configurator YAML syntax Added a note about the .htaccess files included by Symfony apps Made unmapped field example in forms chapter more descriptive [#7507] fix namespace [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests [#7204] link to API doc Added docs for JsonResponse::fromJsonString Added the changes suggested by reviewers [#7620] use generate() in PHP templates before 2.8 Fixed the RST syntax Improve example context Minor formatting changes [#7519] some minor tweaks ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes #6985.