Patch based 2.7 #6985
Closed
Patch based 2.7 #6985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 20, 2016 10:35
The old sentence was confusing. This one works better.
Its better to use e.g. here cause that is just an example. Doesn't always going to be in that path.
The word 'or' is clear. / not so much.
Titles use caps. Unnecessary sentence.
xabbuh
reviewed
Sep 21, 2016
| @@ -108,14 +108,14 @@ via the ``config:dump-reference`` command: | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| $ app/console config:dump-reference AsseticBundle | |||
| $ bin/console config:dump-reference AsseticBundle | |||
There was a problem hiding this comment.
This does only apply to Symfony >= 3.0.
| service as explained in `Services & Configuration`_. This, of course, will only | ||
| work if the type is referred to by its alias rather than being instantiated, | ||
| e.g.:: | ||
| Form types are referred to by their fully-qualified class name:: |
There was a problem hiding this comment.
This is only true for Symfony >= 2.8.
There was a problem hiding this comment.
But we may want to remove this paragraph entirely for the 2.7 docs and only talk about form type extensions.
xabbuh
requested changes
Sep 21, 2016
There was a problem hiding this comment.
@franciscocorrales I left some minor comments that should be addressed. But overall I like your suggestions.
This does only apply to Symfony >= 3.0.
|
@franciscocorrales thanks for contributing these improvements. The PR stalled and has conflicts, so I'm finishing it in #7490. I reused your original commits, so you'll get full credit for your work. Thanks! |
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
…javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Minor fixes about bundle overridding This finishes #6985. Commits ------- c9a52ae Added the changes suggested by reviewers d5cd8d0 Reworded the section about form overridding 600d302 Update installation.rst 62bfc21 Update prepend_extension.rst 2f837d6 Update override.rst 3433e50 Update installation.rst f684bdd Update inheritance.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc changes on 2.7