Improve specification explanation #7601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 2616 and RFC 7234 define that a recipient MUST ignore Expires header if one of `s-max-age` or `max-age` header is defined.
xabbuh
reviewed
Mar 13, 2017
http_cache/expiration.rst
Outdated
| .. _`expiration model`: http://tools.ietf.org/html/rfc2616#section-13.2 | ||
| .. _`FrameworkExtraBundle documentation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/cache.html | ||
| .. _`RFC 7234 - Caching`: https://tools.ietf.org/html/rfc7234 |
There was a problem hiding this comment.
I would make this a deep link to https://tools.ietf.org/html/rfc7234#section-5.3
There was a problem hiding this comment.
Ah no, maybe that's not the best idea as https://tools.ietf.org/html/rfc7234#section-4.2.1 also contains information about the process that must be applied.
There was a problem hiding this comment.
Sure, the process is well explained in section 4.2.1
xabbuh
reviewed
Mar 13, 2017
http_cache/expiration.rst
Outdated
| .. note:: | ||
|
|
||
| Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is | ||
| ignored when a ``s-max-age`` or ``max-age`` header is defined. |
There was a problem hiding this comment.
In fact, s-maxage (note the missing second dash) and max-age are not headers, but are directives of the Cache-Control header.
HeahDude
reviewed
Mar 13, 2017
http_cache/expiration.rst
Outdated
| .. note:: | ||
|
|
||
| Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is | ||
| ignored when a ``s-max-age`` or ``max-age`` directives are defined. |
There was a problem hiding this comment.
You should remove the a before directives.
xabbuh
reviewed
Mar 13, 2017
http_cache/expiration.rst
Outdated
| .. note:: | ||
|
|
||
| Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is | ||
| ignored when ``s-max-age`` or ``max-age`` directives are defined. |
There was a problem hiding this comment.
[...] when the s-maxage or max-age directive of the Cache-Control header is defined.
There was a problem hiding this comment.
@xabbuh Minor comment, I don't get this change, it seems to me that both can be set at the same time, does it matter?
There was a problem hiding this comment.
Yes, but it is enough for one of them to be present in order to ignore the Expires header.
HeahDude
approved these changes
Mar 13, 2017
|
Thank you @matthieu88160. |
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
…guiluz) This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7601). Discussion ---------- Improve specification explanation RFC 2616 and RFC 7234 define that a recipient MUST ignore Expires header if one of `s-max-age` or `max-age` header is defined. Commits ------- ce64af5 Update expiration.rst 46e6408 Update expiration.rst b66e4d7 Update expiration.rst 13102da Update expiration.rst 8666bed Minor reword and fixed the line length 232c029 Improve specification explanation
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
* 2.7: (31 commits) Fixed the RST syntax Improve example context [#5621] Enhancing example of using bundle config [#7601] minor tweak Update expiration.rst Update expiration.rst Update expiration.rst Update expiration.rst Minor reword and fixed the line length Improve specification explanation [#7664] minor wording tweak Rewords and minor fixes Add an explanation about «constraints» validation [#7645] enumerate ordered list items implicitly Adding a new article about "Creating a Bug Reproducer" Fixed a syntax issue Use backticks #7311 choice_value callback argument can be null Fixed broken links for nginx & FastCgiExternalServer Update dialoghelper.rst ...
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
* 2.8: (46 commits) [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests Added the changes suggested by reviewers [#7620] use generate() in PHP templates before 2.8 Fixed the RST syntax Improve example context [#5621] Enhancing example of using bundle config [#7601] minor tweak Update expiration.rst Update expiration.rst Update expiration.rst Update expiration.rst Minor reword and fixed the line length Improve specification explanation [#7664] minor wording tweak Rewords and minor fixes Add an explanation about «constraints» validation [#7645] enumerate ordered list items implicitly Adding a new article about "Creating a Bug Reproducer" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 2616 and RFC 7234 define that a recipient MUST ignore Expires header if one of
s-max-ageormax-ageheader is defined.