Adding a new article about "Creating a Bug Reproducer" #7645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Mar 17, 2017
contributing/code/reproducer.rst
Outdated
| // First, run "composer require symfony/validator" | ||
| // Then, execute this file: | ||
| <?php | ||
| require_once __DIR__.'/../vendor/autoload.php'; |
There was a problem hiding this comment.
The path to the autoload.php should be __DIR__.'/vendor/autoload.php' (if composer.lock and PHP script are in the same dir).
|
Casually I had left a comment in "Symfony Community Survey 2017" related to this idea of making viable the way to reproduce issues through a fiddle application with support to install the needed vendors and run/share it. The first part, by using a PHP script to test Symfony components would work perfectly (with some initial code templates to start). It is my proof idea: https://phpcomposerfiddle.herokuapp.com (nonprofit) ❤️ 🆘 |
|
I think it's a good idea to link to Twig's fiddle and this Symfony's fiddle when they are ready (Twig one seems mature, but the other one is still too new). |
|
👍 for this idea |
roman-1983
approved these changes
Mar 19, 2017
|
Thank you @javiereguiluz. |
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
…aviereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #7645). Discussion ---------- Adding a new article about "Creating a Bug Reproducer" It's very common for us to tell issue reportes to create a bug reproducer. We usually tell them *"fork the Symfony Standard edition and reproduce the bug"* ... but I don't like that and I'm sure that most people don't understand what we're talking about. I propose to add this article to explain as simple as possible what do we expect them to do, so we can link to this article in every issue of the Symfony code repo. --- If you are thinking about merging this article with others of the "Contributing" section ... let's do that later. I want to change a lot of things here ... but let's do one thing at a time. Thanks! Commits ------- b5a61ca Adding a new article about "Creating a Bug Reproducer"
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
* 2.7: (31 commits) Fixed the RST syntax Improve example context [#5621] Enhancing example of using bundle config [#7601] minor tweak Update expiration.rst Update expiration.rst Update expiration.rst Update expiration.rst Minor reword and fixed the line length Improve specification explanation [#7664] minor wording tweak Rewords and minor fixes Add an explanation about «constraints» validation [#7645] enumerate ordered list items implicitly Adding a new article about "Creating a Bug Reproducer" Fixed a syntax issue Use backticks #7311 choice_value callback argument can be null Fixed broken links for nginx & FastCgiExternalServer Update dialoghelper.rst ...
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
* 2.8: (46 commits) [#7507] fix component name [#7490] minor typo fix Added a note about redirections to absolute URLs in tests Added the changes suggested by reviewers [#7620] use generate() in PHP templates before 2.8 Fixed the RST syntax Improve example context [#5621] Enhancing example of using bundle config [#7601] minor tweak Update expiration.rst Update expiration.rst Update expiration.rst Update expiration.rst Minor reword and fixed the line length Improve specification explanation [#7664] minor wording tweak Rewords and minor fixes Add an explanation about «constraints» validation [#7645] enumerate ordered list items implicitly Adding a new article about "Creating a Bug Reproducer" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very common for us to tell issue reportes to create a bug reproducer. We usually tell them "fork the Symfony Standard edition and reproduce the bug" ... but I don't like that and I'm sure that most people don't understand what we're talking about.
I propose to add this article to explain as simple as possible what do we expect them to do, so we can link to this article in every issue of the Symfony code repo.
If you are thinking about merging this article with others of the "Contributing" section ... let's do that later. I want to change a lot of things here ... but let's do one thing at a time. Thanks!