[Routing] Remove note about automatic redirect #12247
8000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comment for template location.
…ous) This PR was merged into the 4.3 branch. Discussion ---------- Progress Bar Section -- Change CodeBlock Change CodeBlock Terminal for CodeBlock Console Example : https://symfony.com/doc/current/components/console/helpers/progressbar.html <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 72a5328 Progress Bar Section -- Change CodeBlock
This PR was squashed before being merged into the 4.3 branch (closes symfony#11903). Discussion ---------- [PhpUnitBridge] Add docs for ClassExistsMock fixes symfony#10528 Commits ------- 2534240 [PhpUnitBridge] Add docs for ClassExistsMock
…Stark) This PR was merged into the 3.4 branch. Discussion ---------- Use versionadded instead of note directive <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 46d3cc7 Use versionadded instead of note directive
* 3.4: Use versionadded instead of note directive
… in Timezone constraint (javiereguiluz) This PR was squashed before being merged into the 4.3 branch (closes symfony#12057). Discussion ---------- [Validation] Documented the intlCompatible option in Timezone constraint Fixes symfony#11502. In addition to documenting the `intlCompatible` option, it sorts all the options alphabetically, like we always do for constraints. Commits ------- 6440a37 [Validation] Documented the intlCompatible option in Timezone constraint
…Garious) This PR was merged into the 4.3 branch. Discussion ---------- SwiftMailer Section - Added more information Add comment for template location. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- f4db2c5 SwiftMailer Section - Added more information
…viereguiluz) This PR was squashed before being merged into the 4.3 branch (closes symfony#11803). Discussion ---------- More updates related to Symfony configuration This makes several changes related to config. 1) Now that the TOC is displayed so prominently, it's easy to spot things to improve in the article hierarchy. So, I've made the following changes (left: before, right: after):  2) the multiple ".env" files section has been reworded and now it follows the same structure as the comments of the associated recipe, which I think are better. 3) The main Confgi article now explains the different kinds of params you can define ... so we've deleted the service_container/parameters.rst article which is no longer needed. 4) The main Config article adds a new section to explain how to get config values in services and controllers. With these changes I considered finished the main Config article. Thanks. Commits ------- c7a62b8 More updates related to Symfony configuration
…re defined (javiereguiluz) This PR was squashed before being merged into the 4.3 branch (closes symfony#12066). Discussion ---------- [Configuration] Simplified how default env vars are defined Changes according to @nicolas-grekas' comments in https://twitter.com/arnolanglade/status/1156107440775192576 Commits ------- 9581c06 [Configuration] Simplified how default env vars are defined
… (javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [Dotenv] Added a note about the order of env vars Fixes symfony#12008. Commits ------- f462027 [Dotenv] Added a note about the order of env vars
* 3.4: [Dotenv] Added a note about the order of env vars
… (javiereguiluz) This PR was merged into the 4.3 branch. Discussion ---------- Fixed a syntax issue in a configuration directive Originally spotted by @TheGarious and reported on Symfony's Slack. Commits ------- c7dd2d6 Fixed a syntax issue in a configuration directive
This PR was merged into the 4.3 branch. Discussion ---------- Fixed some Windows console commands Commits ------- 5012ca3 Fixed some Windows console commands
…ks (javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Updated the lexer used to highlight terminal blocks This should fix symfony#12060 and all the related issues which were reported in the past. Now we only consider something is a Windows prompt if it starts with `C:\` and ends with `>`, so `C:\>`, `C:\Users\Administrator>`, `C:\Users\Someone\Projects\AcmeProject>`, etc. Commits ------- 2e2a869 Updated the lexer used to highlight terminal blocks
* 3.4: Updated the lexer used to highlight terminal blocks
This PR was merged into the 4.3 branch. Discussion ---------- Update serializer.rst Fix name variable in code exemple. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- cd23bde Update serializer.rst
…(TheGarious) This PR was merged into the 4.3 branch. Discussion ---------- Update output from make crud and make controller Add more detail output from command make:crud and make:controller <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 2e0ef12 Update output from make crud and make controller
…mit (jbdelhommeau) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes symfony#12072). Discussion ---------- Remove strict true === $user['showEmail'] on preSubmit <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> On the pre submit example. Strict condition will be used. `true === $user['showEmail']`. In pre submit value of data are not normalized. Strict operator `true === $user['showEmail']` is wrong. If we want used strict operator we can use: `'1' === $user['showEmail']`. but in case of checkbox is not checked the key `showEmail` is not set. I prefere use this condition: `isset($user['showEmail']) && $user['showEmail']` or maybe `false === empty($user['showEmail'])` ? Commits ------- 122ccaa Remove strict true === $user['showEmail'] on preSubmit
* 3.4: Remove strict true === $user['showEmail'] on preSubmit
This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes symfony#12232). Discussion ---------- Fix some examples The dumper requires a Cloner\Data object instead of the original variables <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- aecc29a Fix some examples
* 3.4: Fix some examples
…(jdreesen) This PR was merged into the 3.4 branch. Discussion ---------- Fix comment to actually be a comment in code block <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 090065c Fix comment to actually be a comment in code block
This PR was merged into the 3.4 branch. Discussion ---------- Fix rendering of error code block This is [how it looks](https://symfony.com/doc/3.4/frontend/encore/simple-example.html#using-sass-less-stylus) currently:  `sass-loader@^7.0.1` is blue because it is currently rendered as a `mailto:...` link. Commits ------- 1953f73 Fix rendering of error code block
* 3.4: Fix comment to actually be a comment in code block Fix rendering of error code block
|
Note: this change should be applied to all versions 4.1+. |
"!!set" was present twice in the Unsupported features.
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes symfony#12251). Discussion ---------- Remove duplicated !!set tag "!!set" was present twice in the Unsupported features. Commits ------- ebc9e28 Remove duplicated !!set tag
* 3.4: Remove duplicated !!set tag
This PR was merged into the 4.3 branch. Discussion ---------- fix word: domain => subdomain <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 188861a fix word: domain => subdomain
…on (stephanvierkant) This PR was submitted for the 4.2 branch but it was squashed and merged into the 4.3 branch instead (closes symfony#12252). Discussion ---------- [DX] Longer variable names in Mercure documentation Using meaningful variable names (not just two or three characters) improves readability of the code at the cost of just a couple of extra keystrokes/bytes. Commits ------- 31f5fb6 [DX] Longer variable names in Mercure documentation
14bf4f8 to
4065d4c
Compare
|
@xavierleune thanks for this contribution! I tried to merge it with our tool and change its branch (it should go to 4.3 because 4.1 is no longer maintained). However, I failed spectacularly and destroyed your pull request. I'm sorry and I apologize for that. I've created #12256 to replace this and that's why I'm closing it. |
|
@javiereguiluz Thanks for the new pull request ! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 2, 2019
…viereguiluz) This PR was merged into the 4.3 branch. Discussion ---------- [Routing] Removed a note about automatic redirection Same as #12247 (created by @xavierleune) but for 4.3 branch. Commits ------- d3a028a [Routing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this comment by @nicolas-grekas, this assertion is not true, as "routes with and without trailing slashes are considered canonically equivalent."