8000 [DX] Longer variable names in Mercure documentation by stephanvierkant · Pull Request #12252 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[DX] Longer variable names in Mercure documentation #12252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2019
Merged

[DX] Longer variable names in Mercure documentation #12252

merged 1 commit into from
Sep 2, 2019

Conversation

stephanvierkant
Copy link
Contributor

Using meaningful variable names (not just two or three characters) improves readability of the code at the cost of just a couple of extra keystrokes/bytes.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Sep 2, 2019
@javiereguiluz
Copy link
Member

@stephanvierkant thanks for this contribution. The code is much more readable now! We merged this in 4.3 because the 4.2 branch is no longer maintained.

@javiereguiluz javiereguiluz changed the base branch from 4.2 to 4.3 September 2, 2019 10:13
javiereguiluz added a commit that referenced this pull request Sep 2, 2019
@javiereguiluz
minor #12252 [DX] Longer variable names in Mercure documentation (ste…
4065d4c 
…phanvierkant)

This PR was submitted for the 4.2 branch but it was squashed and merged into the 4.3 branch instead (closes #12252).

Discussion
----------

[DX] Longer variable names in Mercure documentation

Using meaningful variable names (not just two or three characters) improves readability of the code at the cost of just a couple of extra keystrokes/bytes.

Commits
-------

31f5fb6 [DX] Longer variable names in Mercure documentation
@javiereguiluz javiereguiluz merged commit 31f5fb6 into symfony:4.3 Sep 2, 2019
@stephanvierkant stephanvierkant deleted the mercure-js-variables branch September 2, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DX Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanvierkant @javiereguiluz @carsonbot
0