8000 Doctrine Section -- Change CodeBlock terminal to CodeBlock console by TheGarious · Pull Request #12060 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Doctrine Section -- Change CodeBlock terminal to CodeBlock console #12060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TheGarious
Copy link
Contributor

In Symfony Docs if you use code block terminal the text color change "New property name (press " is different to "to stop adding fields):"

Example : https://symfony.com/doc/current/doctrine.html#creating-an-entity-class

With code block console this color difference is not applied.

In Symfony Docs if you use code block terminal the text color change  "New property name (press <return>" is different to "to stop adding fields):" 

Example : https://symfony.com/doc/current/doc
8000
trine.html#creating-an-entity-class

With code block console this color difference is not applied.
@TheGarious TheGarious changed the title Change terminal for console Change CodeBlock terminal to CodeBlock console Jul 30, 2019
@TheGarious TheGarious changed the title Change CodeBlock terminal to CodeBlock console Doctrine Section -- Change CodeBlock terminal to CodeBlock console Jul 30, 2019
@OskarStark OskarStark requested a review from javiereguiluz July 31, 2019 06:35
@OskarStark OskarStark added this to the 4.3 milestone Jul 31, 2019
@javiereguiluz
Copy link
Member

Gary, thanks for reporting this problem. Sadly this is not the only place where this kind of errors happen. The real problem is the "lexer" we use to detect "console prompts". We're trying to fix this in #12067.

@TheGarious
Copy link
Contributor Author

Ok, but i change in few page this code block terminal with code block console.

@javiereguiluz
Copy link
Member

I'm not sure, but I think terminal and console are treated the same. bash is similar but different (we use bash for .env files because they shouldn't be displayed inside a terminal).

@TheGarious
Copy link
Contributor Author

When i use CodeBlock Console i don't have this problem of CodeBlock Terminal.

@javiereguiluz
Copy link
Member

Yes, I just saw the difference. Both look the same ... except precisely for the prompt. "terminal" highlights prompts to make them unselectable, whereas "console" doesn't do that. We strongly prefer to use terminal because of that behavior (people in the community asked us to make prompts not selectable to simplify copy+pasting code). So, let's wait and see if #12067 fixes the problem. Thanks.

@TheGarious
Copy link
Contributor Author

Ok good, but one or two pr, i changed this. :(

@TheGarious
Copy link
Contributor Author

@javiereguiluz I close this pr ?

@javiereguiluz
Copy link
Member

Let's keep it open a bit longer until we confirm that this has been fixed by the other pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0