8000 Updated the lexer used to highlight terminal blocks by javiereguiluz · Pull Request #12067 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Updated the lexer used to highlight terminal blocks #12067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

Updated the lexer used to highlight terminal blocks #12067

merged 1 commit into from
Jul 31, 2019

Conversation

javiereguiluz
Copy link
Member

This should fix #12060 and all the related issues which were reported in the past.

Now we only consider something is a Windows prompt if it starts with C:\ and ends with >, so C:\>, C:\Users\Administrator>, C:\Users\Someone\Projects\AcmeProject>, etc.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Jul 31, 2019
@javiereguiluz javiereguiluz mentioned this pull request Jul 31, 2019
Closed
@javiereguiluz javiereguiluz merged commit 2e2a869 into symfony:3.4 Jul 31, 2019
javiereguiluz added a commit that referenced this pull request Jul 31, 2019
@javiereguiluz
minor #12067 Updated the lexer used to highlight terminal blocks (jav…
eebc2e4 
…iereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Updated the lexer used to highlight terminal blocks

This should fix #12060 and all the related issues which were reported in the past.

Now we only consider something is a Windows prompt if it starts with `C:\` and ends with `>`, so `C:\>`, `C:\Users\Administrator>`, `C:\Users\Someone\Projects\AcmeProject>`, etc.

Commits
-------

2e2a869 Updated the lexer used to highlight terminal blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@javiereguiluz @carsonbot
0