[Console] [5.0] Add all type-hint #32318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c11267f to
d7a4b96
Compare
chalasr
reviewed
Jul 2, 2019
d7a4b96 to
72c85c5
Compare
thePanz
reviewed
Jul 3, 2019
57 tasks
72c85c5 to
e9a0657
Compare
e9a0657 to
384c773
Compare
|
Status: Needs Review |
derrabus
requested changes
Jul 7, 2019
c16ae88 to
9c8d6df
Compare
|
Status: Needs Review |
fabpot
requested changes
Jul 8, 2019
9c8d6df to
493fd65
Compare
|
Status: Needs Review |
493fd65 to
26624ed
Compare
fabpot
approved these changes
Jul 8, 2019
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Console] [5.0] Add all type-hint | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | Contributo to #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | not needed <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Add all type-hint to console component whenever it's possible Commits ------- 26624ed [Console] [5.0] Add all type-hint
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Console] add missing type hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | part of #32179 | License | MIT | Doc PR | Fix missing types from #32318 Commits ------- 180c497 [Console] add missing type hints
This was referenced Jul 4, 2021
derrabus
added a commit
that referenced
this pull request
Jul 5, 2021
…uestion by co… (TomasVotruba) This PR was merged into the 5.2 branch. Discussion ---------- [Console] SymfonyStyle - add string type to confirm() $question by co… PR retargeted from Symfony 5.4: #41983 Inspired by & follow up to #41946 by `@nicolas`-grekas <br> This type is always string, see contract https://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102 Also `ConfirmationQuestion` requires `string` strict type bellow Probably forgotten during adding types everywhere in #32318 | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Commits ------- d0c337d [Console] SymfonyStyle - add string type to confirm() $question by contract
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Jul 5, 2021
…uestion by co… (TomasVotruba) This PR was merged into the 5.2 branch. Discussion ---------- [Console] SymfonyStyle - add string type to confirm() $question by co… PR retargeted from Symfony 5.4: symfony/symfony#41983 Inspired by & follow up to symfony/symfony#41946 by `@nicolas`-grekas <br> This type is always string, see contract https://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102 Also `ConfirmationQuestion` requires `string` strict type bellow Probably forgotten during adding types everywhere in symfony/symfony#32318 | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Commits ------- d0c337d524 [Console] SymfonyStyle - add string type to confirm() $question by contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all type-hint to console component whenever it's possible