8000 minor #33059 [Console] add missing type hints (Tobion) · symfony/symfony@f6c5848 · GitHub
[go: up one dir, main page]
Skip to content

Commit f6c5848

Browse files
nicolas-grekasnicolas-grekas
committed
minor #33059 [Console] add missing type hints (Tobion)
This PR was merged into the 5.0-dev branch. Discussion ---------- [Console] add missing type hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | part of #32179 | License | MIT | Doc PR | Fix missing types from #32318 Commits ------- 180c497 [Console] add missing type hints
2 parents b11129f + 180c497 commit f6c5848

File tree

3 files changed

+3
-17
lines changed

3 files changed

+3
-17
lines changed

‎src/Symfony/Component/Console/Helper/DescriptorHelper.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,9 @@ public function __construct()
4848
* * format: string, the output format name
4949
* * raw_text: boolean, sets output type as raw
5050
*
51-
* @param object $object
52-
*
5351
* @throws InvalidArgumentException when the given format is not supported
5452
*/
55-
public function describe(OutputInterface $output, $object, array $options = [])
53+
public function describe(OutputInterface $output, ?object $object, array $options = [])
5654
{
5755
$options = array_merge([
5856
'raw_text' => false,
@@ -70,11 +68,9 @@ public function describe(OutputInterface $output, $object, array $options = [])
7068
/**
7169
* Registers a descriptor.
7270
*
73-
* @param string $format
74-
*
7571
* @return $this
7672
*/
77-
public function register($format, DescriptorInterface $descriptor)
73+
public function register(string $format, DescriptorInterface $descriptor)
7874
{
7975
$this->descriptors[$format] = $descriptor;
8076

‎src/Symfony/Component/Console/Helper/ProgressIndicator.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ public function setMessage(?string $message)
7373

7474
/**
7575
* Starts the indicator output.
76-
*
77-
* @param $message
7876
*/
7977
public function start(string $message)
8078
{

‎src/Symfony/Component/Console/Helper/TableStyle.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,9 @@ public function getCrossingChars(): array
227227
/**
228228
* Sets header cell format.
229229
*
230-
* @param string $cellHeaderFormat
231-
*
232230
* @return $this
233231
*/
234-
public function setCellHeaderFormat($cellHeaderFormat)
232+
public function setCellHeaderFormat(string $cellHeaderFormat)
235233
{
236234
$this->cellHeaderFormat = $cellHeaderFormat;
237235

@@ -251,8 +249,6 @@ public function getCellHeaderFormat()
251249
/**
252250
* Sets row cell format.
253251
*
254-
* @param string $cellRowFormat
255-
*
256252
* @return $this
257253
*/
258254
public function setCellRowFormat(string $cellRowFormat)
@@ -275,8 +271,6 @@ public function getCellRowFormat()
275271
/**
276272
* Sets row cell content format.
277273
*
278-
* @param string $cellRowContentFormat
279-
*
280274
* @return $this
281275
*/
282276
public function setCellRowContentFormat(string $cellRowContentFormat)
@@ -299,8 +293,6 @@ public function getCellRowContentFormat()
299293
/**
300294
* Sets table border format.
301295
*
302-
* @param string $borderFormat
303-
*
304296
* @return $this
305297
*/
306298
public function setBorderFormat(string $borderFormat)

0 commit comments

Comments
 (0)
0