minor #41987 [Console] SymfonyStyle - add string type to confirm() $question by co… (TomasVotruba)

derrabus · derrabus · commit 257666378ccc · 2021-07-05T20:31:41.000+02:00
This PR was merged into the 5.2 branch. Discussion ---------- [Console] SymfonyStyle - add string type to confirm() $question by co… PR retargeted from Symfony 5.4: #41983 Inspired by & follow up to #41946 by `@nicolas`-grekas <br> This type is always string, see contract https://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102 Also `ConfirmationQuestion` requires `string` strict type bellow Probably forgotten during adding types everywhere in #32318 | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Commits ------- d0c337d [Console] SymfonyStyle - add string type to confirm() $question by contract
diff --git a/src/Symfony/Component/Console/Style/SymfonyStyle.php b/src/Symfony/Component/Console/Style/SymfonyStyle.php
@@ -288,7 +288,7 @@ public function askHidden(string $question, callable $validator = null)
     /**
      * {@inheritdoc}
      */
-    public function confirm($question, $default = true)
+    public function confirm(string $question, bool $default = true)
     {
         return $this->askQuestion(new ConfirmationQuestion($question, $default));
     }

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ public function askHidden(string $question, callable $validator = null)`
`288`	`288`	`/**`
`289`	`289`	`* {@inheritdoc}`
`290`	`290`	`*/`
`291`		`- public function confirm($question, $default = true)`
	`291`	`+ public function confirm(string $question, bool $default = true)`
`292`	`292`	`{`
`293`	`293`	`return $this->askQuestion(new ConfirmationQuestion($question, $default));`
`294`	`294`	`}`