SymfonyStyle - add string type to confirm() $question by contract #41983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is always string, see contract https://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102 Also `ConfirmationQuestion` requirest `string` strict type bellow Probably forgotten during symfony@26624ed#diff-9bf955eb9a488c634942b2033efd14a4ca8f56bab5425dfc4219cadf40fc802b
|
Should this target 5.2 branch then? |
OskarStark
reviewed
Jul 5, 2021
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
|
Thanks for feedback 👍 I've opened PR with 5.2 as target #41987 |
derrabus
added a commit
that referenced
this pull request
Jul 5, 2021
…uestion by co… (TomasVotruba) This PR was merged into the 5.2 branch. Discussion ---------- [Console] SymfonyStyle - add string type to confirm() $question by co… PR retargeted from Symfony 5.4: #41983 Inspired by & follow up to #41946 by `@nicolas`-grekas <br> This type is always string, see contract https://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102 Also `ConfirmationQuestion` requires `string` strict type bellow Probably forgotten during adding types everywhere in #32318 | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Commits ------- d0c337d [Console] SymfonyStyle - add string type to confirm() $question by contract
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Jul 5, 2021
…uestion by co… (TomasVotruba) This PR was merged into the 5.2 branch. Discussion ---------- [Console] SymfonyStyle - add string type to confirm() $question by co… PR retargeted from Symfony 5.4: symfony/symfony#41983 Inspired by & follow up to symfony/symfony#41946 by `@nicolas`-grekas <br> This type is always string, see contract https://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102 Also `ConfirmationQuestion` requires `string` strict type bellow Probably forgotten during adding types everywhere in symfony/symfony#32318 | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Commits ------- d0c337d524 [Console] SymfonyStyle - add string type to confirm() $question by contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by & follow up to #41946 by @nicolas-grekas
This type is always string, see contract
symfony/src/Symfony/Component/Console/Style/StyleInterface.php
Line 102 in 5010ebd
Also
ConfirmationQuestionrequiresstringstrict type bellowProbably forgotten during adding types everywhere in #32318