[VarDumper] Add missing getDump in abstract VarDumperTestCase #16126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2015
…tCase (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Add missing getDump in abstract VarDumperTestCase | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16063 | License | MIT | Doc PR | - Just a miss in #16063 Commits ------- 06fdf73 [VarDumper] Add missing getDump in abstract VarDumperTestCase
| } | ||
|
|
||
| private function getVarDumperDump($data) | ||
| private function getDump($data) |
There was a problem hiding this comment.
Any reason this is private in the class but public in the trait?
There was a problem hiding this comment.
Yes, a mistake of mine :-)
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
… trait (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] consistent signature of getDump() in class + trait | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16126 | License | MIT | Doc PR | Commits ------- 48a9e83 consistent signature of getDump() in class + trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a miss in #16063