8000 [VarDumper] Add $this->getDump($var) when using VarDumperTestTrait by nicolas-grekas · Pull Request #16063 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Add $this->getDump($var) when using VarDumperTestTrait #16063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2015
Merged

[VarDumper] Add $this->getDump($var) when using VarDumperTestTrait #16063

merged 1 commit into from
Oct 2, 2015

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

So useful when writing/updating dump fixtures!

@nicolas-grekas nicolas-grekas changed the title [VarDumper] Add $this-getDump($var) when using VarDumperTestTrait [VarDumper] Add $this->getDump($var) when using VarDumperTestTrait Oct 2, 2015
@fabpot
Copy link
Member
fabpot commented Oct 2, 2015

Thank you @nicolas-grekas.

@fabpot fabpot merged commit aa1d578 into symfony:2.8 Oct 2, 2015
fabpot added a commit that referenced this pull request Oct 2, 2015
@fabpot
feature #16063 [VarDumper] Add $this->getDump($var) when using VarDum…
6413fb7 
…perTestTrait (nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[VarDumper] Add $this->getDump($var) when using VarDumperTestTrait

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

So useful when writing/updating dump fixtures!

Commits
-------

aa1d578 [VarDumper] Add $this->getDump($var) when using VarDumperTestTrait
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 5, 2015
Merged
fabpot added a commit that referenced this pull request Oct 5, 2015
@fabpot
minor #16126 [VarDumper] Add missing getDump in abstract VarDumperTes…
3cd5628 
…tCase (nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[VarDumper] Add missing getDump in abstract VarDumperTestCase

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16063
| License       | MIT
| Doc PR        | -

Just a miss in #16063

Commits
-------

06fdf73 [VarDumper] Add missing getDump in abstract VarDumperTestCase
@nicolas-grekas nicolas-grekas deleted the dump-write branch October 6, 2015 07:27
@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @carsonbot
0