minor #16126 [VarDumper] Add missing getDump in abstract VarDumperTestCase (nicolas-grekas)

fabpot · fabpot · commit 3cd562847a75 · 2015-10-05T17:36:38.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Add missing getDump in abstract VarDumperTestCase | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16063 | License | MIT | Doc PR | - Just a miss in #16063 Commits ------- 06fdf73 [VarDumper] Add missing getDump in abstract VarDumperTestCase
diff --git a/src/Symfony/Component/VarDumper/Test/VarDumperTestCase.php b/src/Symfony/Component/VarDumper/Test/VarDumperTestCase.php
@@ -21,15 +21,15 @@ abstract class VarDumperTestCase extends \PHPUnit_Framework_TestCase
 {
     public function assertDumpEquals($dump, $data, $message = '')
     {
-        $this->assertSame(rtrim($dump), $this->getVarDumperDump($data), $message);
+        $this->assertSame(rtrim($dump), $this->getDump($data), $message);
     }
 
     public function assertDumpMatchesFormat($dump, $data, $message = '')
     {
-        $this->assertStringMatchesFormat(rtrim($dump), $this->getVarDumperDump($data), $message);
+        $this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);
     }
 
-    private function getVarDumperDump($data)
+    private function getDump($data)
     {
         $h = fopen('php://memory', 'r+b');
         $cloner = new VarCloner();

Original file line number	Diff line number	Diff line change
`@@ -21,15 +21,15 @@ abstract class VarDumperTestCase extends \PHPUnit_Framework_TestCase`
`21`	`21`	`{`
`22`	`22`	`public function assertDumpEquals($dump, $data, $message = '')`
`23`	`23`	`{`
`24`		`- $this->assertSame(rtrim($dump), $this->getVarDumperDump($data), $message);`
	`24`	`+ $this->assertSame(rtrim($dump), $this->getDump($data), $message);`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`public function assertDumpMatchesFormat($dump, $data, $message = '')`
`28`	`28`	`{`
`29`		`- $this->assertStringMatchesFormat(rtrim($dump), $this->getVarDumperDump($data), $message);`
	`29`	`+ $this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);`
`30`	`30`	`}`
`31`	`31`
`32`		`- private function getVarDumperDump($data)`
	`32`	`+ private function getDump($data)`
`33`	`33`	`{`
`34`	`34`	`$h = fopen('php://memory', 'r+b');`
`35`	`35`	`$cloner = new VarCloner();`