minor #16147 [VarDumper] consistent signature of getDump() in class + trait (xabbuh)

fabpot · fabpot · commit 45a5b005d5f4 · 2015-10-06T18:18:14.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] consistent signature of getDump() in class + trait | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16126 | License | MIT | Doc PR | Commits ------- 48a9e83 consistent signature of getDump() in class + trait
diff --git a/src/Symfony/Component/VarDumper/Test/VarDumperTestCase.php b/src/Symfony/Component/VarDumper/Test/VarDumperTestCase.php
@@ -29,7 +29,7 @@ public function assertDumpMatchesFormat($dump, $data, $message = '')
         $this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);
     }
 
-    private function getDump($data)
+    protected function getDump($data)
     {
         $h = fopen('php://memory', 'r+b');
         $cloner = new VarCloner();
diff --git a/src/Symfony/Component/VarDumper/Test/VarDumperTestTrait.php b/src/Symfony/Component/VarDumper/Test/VarDumperTestTrait.php
@@ -29,7 +29,7 @@ public function assertDumpMatchesFormat($dump, $data, $message = '')
         $this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);
     }
 
-    public function getDump($data)
+    protected function getDump($data)
     {
         $h = fopen('php://memory', 'r+b');
         $cloner = new VarCloner();

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function assertDumpMatchesFormat($dump, $data, $message = '')`
`29`	`29`	`$this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message);`
`30`	`30`	`}`
`31`	`31`
`32`		`- private function getDump($data)`
	`32`	`+ protected function getDump($data)`
`33`	`33`	`{`
`34`	`34`	`$h = fopen('php://memory', 'r+b');`
`35`	`35`	`$cloner = new VarCloner();`