8000 [DependencyInjection] resolve class parameters in service factories by xabbuh · Pull Request #13924 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[DependencyInjection] resolve class parameters in service factories #13924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2015

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 14, 2015
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This is based on the parameter resolving for factories from #13519 and makes the necessary changes for the new factory syntax introduced in Symfony 2.6.

@fabian In #13519, you also updated the PhpDumper to make use of dumpValue(). Should I do the same here (or in this case reopen #13455)?

@xabbuh
Copy link
Member Author
xabbuh commented Mar 15, 2015

I added tests based on #13930.

fabpot added a commit that referenced this pull request Mar 15, 2015
… unit tests (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] `ResolveParameterPlaceHoldersPass` unit tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

When working #13924, I noticed that there were no tests for the `ResolveParameterPlaceHoldersPass` class. So I decided to add them for the `2.3` branch too.

Commits
-------

b8d42b3 `ResolveParameterPlaceHoldersPass` unit tests
@xabbuh
Copy link
Member Author
xabbuh commented Mar 16, 2015

And rebased given that #13930 has been merged.

@nicolas-grekas
Copy link
Member

👍

@fabpot
Copy link
Member
fabpot commented Mar 17, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 8bda37c into symfony:2.6 Mar 17, 2015
fabpot added a commit that referenced this pull request Mar 17, 2015
…factories (xabbuh)

This PR was merged into the 2.6 branch.

Discussion
----------

[DependencyInjection] resolve class parameters in service factories

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This is based on the parameter resolving for factories from #13519 and makes the necessary changes for the new factory syntax introduced in Symfony 2.6.

@fabian In #13519, you also updated the `PhpDumper` to make use of `dumpValue()`. Should I do the same here (or in this case reopen #13455)?

Commits
-------

8bda37c resolve class parameters in service factories
@xabbuh xabbuh deleted the pr-13519 branch March 17, 2015 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0