[2.6] Marked the ResolveParameterPlaceHoldersPassTest as legacy #13941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,7 @@ public function process(ContainerBuilder $container) | |||
| $definition->setFile($parameterBag->resolveValue($definition->getFile())); | |||
| $definition->setArguments($parameterBag->resolveValue($definition->getArguments())); | |||
| $definition->setFactoryClass($parameterBag->resolveValue($definition->getFactoryClass())); | |||
| $definition->setFactory($parameterBag->resolveValue($definition->getFactory())); | |||
There was a problem hiding this comment.
Of you did it this way, parameters would also be responded in factory method names (see #13924 for another approach).
623f2f8 to
11e8632
Compare
|
ping @fabpot @nicolas-grekas |
| class ProjectServiceContainer extends ContainerBuilder | ||
| { | ||
| /** | ||
| * Be careful here: this class is included in Tests\Dumper\GraphvizDumperTest::testDumpWithFrozenCustomClassContainer |
There was a problem hiding this comment.
No need for the "Be careful here" prefix :)
There was a problem hiding this comment.
see also #13947 :) (though I think it's easier to merge this and close the other PR)
|
Thanks guys :) Changes have been made. |
|
Thank you @saro0h. |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2015
… legacy (saro0h) This PR was merged into the 2.6 branch. Discussion ---------- [2.6] Marked the ResolveParameterPlaceHoldersPassTest as legacy | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Splitted the ResolveParameterPlaceHoldersPassTest to obtain a legacy test to avoid deprecation rise. Commits ------- 67ca1f4 Marked the ResolveParameterPlaceHoldersPassTest as legacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitted the ResolveParameterPlaceHoldersPassTest to obtain a legacy test to avoid deprecation rise.