[DependencyInjection] fixed service resolution for factories #13519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +55,7 @@ | |||
| ; | |||
| $container-> | |||
| register('factory_service', 'Bar')-> | |||
| setFactoryService('foo.baz')-> | |||
| setFactoryService('%foo_baz_service%')-> | |||
There was a problem hiding this comment.
FWIW, I think it was a mistake to support this use case, but as it is, we should support it thoroughly.
76ccf15 to
5778721
Compare
| return sprintf(" $return{$instantiation}%s->%s(%s);\n", $this->getServiceCall($definition->getFactoryService()), $definition->getFactoryMethod(), implode(', ', $arguments)); | ||
| $service = $this->dumpValue($definition->getFactoryService()); | ||
|
|
||
| return sprintf(" $return{$instantiation}%s->%s(%s);\n", 0 === strpos($service, '$') ? sprintf('$this->get(%s)', $service) : $this->getServiceCall($definition->getFactoryService()), $definition->getFactoryMethod(), implode(', ', $arguments)); |
There was a problem hiding this comment.
do we really need this logic here ? I don't understand the goal of the $ check changing the way to dump things. $definition->getFactoryService() will always return a service id here, given you resolve it in the compiler pass
There was a problem hiding this comment.
btw, do we really need to support the case of parameters for factory services ? I does not make sense IMO. This is a use case for aliases instead.
There was a problem hiding this comment.
IIRC, it's because it's supported by the new way of defining factories. But you're right, it does not really make sense. I'm going to drop this.
59b8137 to
f86ad95
Compare
|
I've removed some code, should be ready now. ping @symfony/deciders |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2015
…es (fabpot) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] fixed service resolution for factories | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13455 | License | MIT | Doc PR | n/a In the service container, factories can be defined with a class/method pair or a service/method pair. The class or service value can be a container parameter, but it was not supported everywhere, this PR fixes that. Note that the method can never be a container parameter as this is supported nowhere in the current code, so this has not been changed. Another PR will fix the 2.6 way of configuring a factory. Commits ------- f86ad95 [DependencyInjection] fixed service resolution for factories
weaverryan
added a commit
to weaverryan/symfony
that referenced
this pull request
Mar 14, 2015
fabpot
added a commit
that referenced
this pull request
Mar 15, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Fixing wrong variable name from #13519 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13519 | License | MIT | Doc PR | n/a Hi guys! I'm currently seeing an undefined variable in the `PhpDumper` on all branches. I think it was added inadvertently in #13519, so unless I'm totally missing something, this should be an easy merge. Thanks! Commits ------- 3ae52ed Fixing wrong variable name from #13519
fabpot
added a commit
that referenced
this pull request
Mar 15, 2015
* 2.3: `ResolveParameterPlaceHoldersPass` unit tests Fixing wrong variable name from #13519
fabpot
added a commit
that referenced
this pull request
Mar 15, 2015
* 2.6: `ResolveParameterPlaceHoldersPass` unit tests Fixing wrong variable name from #13519 [translation][initialize cache] Remove dead code. Conflicts: src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
fabpot
added a commit
that referenced
this pull request
Mar 17, 2015
…factories (xabbuh) This PR was merged into the 2.6 branch. Discussion ---------- [DependencyInjection] resolve class parameters in service factories | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is based on the parameter resolving for factories from #13519 and makes the necessary changes for the new factory syntax introduced in Symfony 2.6. @fabian In #13519, you also updated the `PhpDumper` to make use of `dumpValue()`. Should I do the same here (or in this case reopen #13455)? Commits ------- 8bda37c resolve class parameters in service factories
fabpot
added a commit
that referenced
this pull request
Mar 17, 2015
* 2.7: `ResolveParameterPlaceHoldersPass` unit tests Fixing wrong variable name from #13519 [translation][initialize cache] Remove dead code. [DependencyInjection] fixed service resolution for factories [HttpKernel] Throw a LogicException when kernel.exception does not led to a Response [FrameworkBundle] Added domain column when debugging translations [PhpUnitBridge] do not replace but require-dev in symfony/symfony [acl][command][SecurityBundle] Fixed user input option mode to be an Array Conflicts: composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the service container, factories can be defined with a class/method pair or a service/method pair.
The class or service value can be a container parameter, but it was not supported everywhere, this PR fixes that.
Note that the method can never be a container parameter as this is supported nowhere in the current code, so this has not been changed.
Another PR will fix the 2.6 way of configuring a factory.