8000 [DependencyInjection] `ResolveParameterPlaceHoldersPass` unit tests by xabbuh · Pull Request #13930 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] ResolveParameterPlaceHoldersPass unit tests #13930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2015
Merged

[DependencyInjection] ResolveParameterPlaceHoldersPass unit tests #13930

merged 1 commit into from
Mar 15, 2015

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 15, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

When working #13924, I noticed that there were no tests for the ResolveParameterPlaceHoldersPass class. So I decided to add them for the 2.3 branch too.

@xabbuh xabbuh mentioned this pull request Mar 15, 2015
Merged
@fabpot
Copy link
Member
fabpot commented Mar 15, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit b8d42b3 into symfony:2.3 Mar 15, 2015
fabpot added a commit that referenced this pull request Mar 15, 2015
@fabpot
minor #13930 [DependencyInjection] ResolveParameterPlaceHoldersPass…
d50f0a8 
… unit tests (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] `ResolveParameterPlaceHoldersPass` unit tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

When working #13924, I noticed that there were no tests for the `ResolveParameterPlaceHoldersPass` class. So I decided to add them for the `2.3` branch too.

Commits
-------

b8d42b3 `ResolveParameterPlaceHoldersPass` unit tests
@xabbuh xabbuh deleted the resolve-parameter-placeholders-pass-tests branch March 16, 2015 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xabbuh @fabpot
0