8000 switch aten_headers to use strip_include_prefix instead of includes by dagitses · Pull Request #77865 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

switch aten_headers to use strip_include_prefix instead of includes #77865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 33 commits into from
Closed

switch aten_headers to use strip_include_prefix instead of includes #77865

wants to merge 33 commits into from

Conversation

dagitses
Copy link
Collaborator
@dagitses dagitses commented May 19, 2022 •
edited
Loading

switch aten_headers to use strip_include_prefix instead of includes
09b61a1 
This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 19, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit 0940115 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-07-12T17:10:42.7991779Z �[0m�[1m�[31mERROR...c1plus: some warnings being treated as errors\n" } 
2022-07-12T17:10:42.7224612Z �[32mINFO: �[0mElapsed time: 85.530s, Critical Path: 22.74s
2022-07-12T17:10:42.7235054Z �[32mINFO: �[0m1140 processes: 861 internal, 1 local, 278 processwrapper-sandbox.
2022-07-12T17:10:42.7239282Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:10:42.7458736Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-07-12T17:10:42.7709579Z �[0m+ sccache_epilogue
2022-07-12T17:10:42.7710165Z + echo '::group::Sccache Compilation Log'
2022-07-12T17:10:42.7711178Z ##[group]Sccache Compilation Log
2022-07-12T17:10:42.7711739Z + echo '=================== sccache compilation log ==================='
2022-07-12T17:10:42.7712167Z =================== sccache compilation log ===================
2022-07-12T17:10:42.7712687Z + python /var/lib/jenkins/workspace/.jenkins/pytorch/print_sccache_log.py /var/lib/jenkins/sccache_error.log
2022-07-12T17:10:42.7991779Z �[0m�[1m�[31mERROR�[0m 2022-07-12T17:10:42Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "In file included from bazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/native/CPUBlas.h:3:0,\n                 from bazel-out/k8-fastbuild/bin/aten/src/ATen/native/cpu/BlasKernel.cpp.DEFAULT.cpp:3:\nbazel-out/k8-fastbuild/bin/_virtual_includes/aten_headers/ATen/OpMathType.h:33:17: error: \'c10::ScalarType at::{anonymous}::toOpMathType(c10::ScalarType)\' defined but not used [-Werror=unused-function]\n c10::ScalarType toOpMathType(const c10::ScalarType type) {\n                 ^~~~~~~~~~~~\ncc1plus: some warnings being treated as errors\n" }
2022-07-12T17:10:42.7993202Z 
2022-07-12T17:10:42.8016859Z + echo '=========== If your build fails, please take a look at the log above for possible reasons ==========='
2022-07-12T17:10:42.8018122Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2022-07-12T17:10:42.8019560Z + sccache --show-stats
2022-07-12T17:10:42.8137123Z Compile requests                    193
2022-07-12T17:10:42.8138300Z Compile requests executed           181
2022-07-12T17:10:42.8139673Z Cache hits                          166
2022-07-12T17:10:42.8141043Z Cache hits (C/C++)                  166
2022-07-12T17:10:42.8142385Z Cache misses                          0
2022-07-12T17:10:42.8143746Z Cache timeouts                        0
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced May 19, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Update on "switch aten_headers to use strip_include_prefix instead of…
fa4a98f 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
dagitses pushed a commit that referenced this pull request May 19, 2022
switch aten_headers to use strip_include_prefix instead of includes
a036a5c 
Pull Request resolved: #77865

This is Bazel best practices and easier to maintain.
ghstack-source-id: 156812099

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)
Update on "switch aten_headers to use strip_include_prefix instead of…
4121fd1
8000 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
43e59d1 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
d857401 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
dagitses pushed a commit that referenced this pull request May 20, 2022
switch aten_headers to use strip_include_prefix instead of includes
a05d0f8 
Pull Request resolved: #77865

This is Bazel best practices and easier to maintain.
ghstack-source-id: 156812099

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)
Update on "switch aten_headers to use strip_include_prefix instead of…
677fb76 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
dagitses pushed a commit that referenced this pull request May 20, 2022
switch aten_headers to use strip_include_prefix instead of includes
b9c3fd5 
Pull Request resolved: #77865

This is Bazel best practices and easier to maintain.
ghstack-source-id: 156812099

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)
Update on "switch aten_headers to use strip_include_prefix instead of…
88920c6 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
This was referenced May 23, 2022
Closed
Closed
Update on "switch aten_headers to use strip_include_prefix instead of…
170e627 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 23, 2022
Closed
Michael Andreas Dagitses added 6 commits May 23, 2022 10:36
Update on "switch aten_headers to use strip_include_prefix instead of…
fe621e9 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
b7920b6 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
032bdbd 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
e19bbd7 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
e7d898b 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
4e240aa 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 31, 2022
Closed
Update on "switch aten_headers to use strip_include_prefix instead of…
21d4b2b 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 31, 2022
Closed
Michael Andreas Dagitses added 2 commits June 2, 2022 13:23
Update on "switch aten_headers to use strip_include_prefix instead of…
abf06d3 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
89dbd9f 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
This was referenced Jun 17, 2022
Closed
Closed
Michael Andreas Dagitses added 6 commits June 20, 2022 08:09
Update on "switch aten_headers to use strip_include_prefix instead of…
1f6d88e 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
5747b3c 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
a4c6592 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
c3a9eba 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
44fb736 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
0859106 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Jul 6, 2022
Closed
Michael Andreas Dagitses added 2 commits July 8, 2022 07:25
Update on "switch aten_headers to use strip_include_prefix instead of…
f9701e8 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
Update on "switch aten_headers to use strip_include_prefix instead of…
0940115 
… includes"

This is Bazel best practices and easier to maintain.

Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/)

[ghstack-poisoned]
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactiv 8000 ity.

@github-actions github-actions bot added the Stale label Sep 10, 2022
@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

CLA Not Signed

@github-actions github-actions bot closed this Nov 3, 2022
@dagitses dagitses deleted the gh/dagitses/347/head branch November 19, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagitses @facebook-github-bot
0