Update on "switch aten_headers to use strip_include_prefix instead of includes"

Michael Andreas Dagitses · Michael Andreas Dagitses · commit fa4a98fe367f · 2022-05-19T10:58:30.000-07:00
This is Bazel best practices and easier to maintain. Differential Revision: [D36521515](https://our.internmc.facebook.com/intern/diff/D36521515/) [ghstack-poisoned]
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -215,7 +215,7 @@ header_template_rule(
 
 cc_library(
     name = "aten_core_headers",
-    hdrs = aten_core_hdrs(),
+    hdrs = aten_core_hdrs(rules = rules),
     strip_include_prefix = "aten/src/",
     deps = ["//c10:headers"],
 )
@@ -233,7 +233,7 @@ cc_library(
         "aten/src/TH/**/*.cpp",
         "aten/src/THC/*.cuh",
         "aten/src/THC/generic/*.cu",
-    ], exclude = aten_core_hdrs()
+    ], exclude = aten_core_hdrs(rules = rules)
     ) + [
         ":aten_src_ATen_config",
         ":gen_aten",
diff --git a/build.bzl b/build.bzl
@@ -124,13 +124,13 @@ def define_targets(rules):
         tools = ["//tools/setup_helpers:gen_version_header"],
     )
 
-def aten_core_hdrs():
+def aten_core_hdrs(rules):
     """The source files that are part of the aten_core_headers target.
 
     Note that this is a function because globs are not permitted at
     global scope in Starlark.
     """
-    return glob([
+    return rules.glob([
         "aten/src/ATen/core/*.h",
         "aten/src/ATen/ops/*.h",
         "aten/src/ATen/core/boxing/*.h",
