10000 move ufunc_defs.bzl to the top-level by dagitses · Pull Request #77749 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

move ufunc_defs.bzl to the top-level #77749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 45 commits into from

Conversation

dagitses
Copy link
Collaborator
@dagitses dagitses commented May 18, 2022

Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 18, 2022

🔗 Helpful links

❌ 1 New Failures

As of commit 4084b05 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-31T17:55:15.6515555Z The PR is introduc...m to confirm whether this change is wanted or not.
2022-05-31T17:55:15.6497762Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> (str _0)
2022-05-31T17:55:15.6499635Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-05-31T17:55:15.6501372Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-05-31T17:55:15.6503379Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> (__torch__.torch.classes.profiling.SourceRef _0)
2022-05-31T17:55:15.6506070Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> (Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0)
2022-05-31T17:55:15.6507170Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-31T17:55:15.6508779Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-31T17:55:15.6510409Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-31T17:55:15.6513274Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> (__torch__.torch.classes.profiling.SourceStats[] _0)
2022-05-31T17:55:15.6514847Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (NoneType _0)
2022-05-31T17:55:15.6515555Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-05-31T17:55:15.6516076Z 
2022-05-31T17:55:15.6516209Z Broken ops: [
2022-05-31T17:55:15.6516898Z 	prims::uniform(int[] shape, *, Scalar low, Scalar high, int dtype, Device device) -> (Tensor)
2022-05-31T17:55:15.6517733Z 	prims::empty_strided(int[] shape, int[] strides, *, int dtype, Device device, bool requires_grad) -> (Tensor)
2022-05-31T17:55:15.6518555Z 	prims::var(Tensor inp, int[]? dims, *, int correction, int? output_dtype=None) -> (Tensor)
2022-05-31T17:55:15.6518989Z 	prims::minium_value(int dtype) -> (Scalar)
2022-05-31T17:55:15.6519354Z 	prims::maximum_value(int dtype) -> (Scalar)
2022-05-31T17:55:15.6519622Z 	prims::item(Tensor a) -> (Scalar)
2022-05-31T17:55:15.6519936Z 	prims::where(Tensor pred, Tensor a, Tensor b) -> (Tensor)
2022-05-31T17:55:15.6520405Z 	prims::cat(Tensor[] tensors, int dim) -> (Tensor)

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 5 commits May 18, 2022 09:17
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 2 commits May 18, 2022 12:02
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 3 commits May 18, 2022 14:11
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 11 commits May 20, 2022 19:33
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 2 commits May 23, 2022 09:58
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 6 commits May 23, 2022 10:36
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Configerator supports this location already. This needs to be in the
top-level so that caffe2/build.bzl can load it via relative load
regardless of the build system used.

Differential Revision: [D36481463](https://our.internmc.facebook.com/intern/diff/D36481463/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481463/)!

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0