8000 move fbcode ATEN_CORE_H to shared build structure by dagitses · Pull Request #77863 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

move fbcode ATEN_CORE_H to shared build structure #77863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from

Conversation

We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 19, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b5bdf47 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Michael Andreas Dagitses added 6 commits May 19, 2022 10:58
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 6 commits May 23, 2022 07:13
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 6 commits May 23, 2022 10:36
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@kit1980 kit1980 added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 3, 2022
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 6 commits June 20, 2022 08:09
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Jul 6, 2022
Michael Andreas Dagitses added 2 commits July 8, 2022 07:25
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
We're about to start using this in Bazel.

Differential Revision: [D36521516](https://our.internmc.facebook.com/intern/diff/D36521516/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36521516/)!

[ghstack-poisoned]
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Sep 11, 2022
@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

@github-actions github-actions bot closed this Nov 3, 2022
@dagitses dagitses deleted the gh/dagitses/345/head branch November 19, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0