[SetSubclass] [wip] Add support for user defined sets #153553

guilhermeleobas · 2025-05-14T16:53:28Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

[ghstack-poisoned]

pytorch-bot · 2025-05-14T16:53:31Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153553

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

CUDA not found in NVIDIA runners

❌ 36 New Failures, 11 Unrelated Failures

As of commit 31a1eed with merge base 62d8e3c ():

NEW FAILURES - The following jobs have failed:

Check Labels / Check labels (gh)
RuntimeError: Error checking labels: PR does not have required labels
Lint / lintrunner-noclang / linux-job (gh)
>>> Lint for torch/_dynamo/variables/builder.py:
pull / linux-focal-cuda12.6-py3.10-gcc11 / test (default, 1, 5, linux.4xlarge.nvidia.gpu) (gh)
dynamo/test_sets.py::TestSetMethods::test_set_inplace_binary_ops_SetSubclass_op_iand
pull / linux-focal-cuda12.6-py3.10-gcc11 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh)
dynamo/test_functions.py::DefaultsTests::test_keyword
pull / linux-focal-cuda12.6-py3.10-gcc11 / test (default, 3, 5, linux.4xlarge.nvidia.gpu) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_set_update_dynamic_shapes
pull / linux-focal-cuda12.6-py3.10-gcc11 / test (default, 4, 5, linux.4xlarge.nvidia.gpu) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_frozenset_torch_func_contains_dynamic_shapes
pull / linux-focal-cuda12.6-py3.10-gcc11 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh)
dynamo/test_dicts.py::DictTests::test_builtin_or_with_invalid_types
pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 1, 5, linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
dynamo/test_sets.py::TestSetMethods::test_set_inplace_binary_ops_SetSubclass_op_iand
pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 3, 5, linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
dynamo/test_functions.py::DefaultsTests::test_keyword
pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 4, 5, linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_frozenset_torch_func_contains_dynamic_shapes
pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 5, 5, linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
dynamo/test_dicts.py::DictTests::test_builtin_or_with_invalid_types
pull / linux-focal-py3.13-clang10 / test (default, 1, 5, linux.4xlarge) (gh)
dynamo/test_sets.py::TestSetMethods::test_set_inplace_binary_ops_SetSubclass_op_iand
pull / linux-focal-py3.13-clang10 / test (default, 2, 5, linux.4xlarge) (gh)
dynamo/test_functions.py::DefaultsTests::test_keyword
pull / linux-focal-py3.13-clang10 / test (default, 3, 5, linux.4xlarge) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_set_update_dynamic_shapes
pull / linux-focal-py3.13-clang10 / test (default, 4, 5, linux.4xlarge) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_frozenset_torch_func_contains_dynamic_shapes
pull / linux-focal-py3.13-clang10 / test (default, 5, 5, linux.4xlarge) (gh)
dynamo/test_dicts.py::DictTests::test_builtin_or_with_invalid_types
pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 1, 3, linux.2xlarge) (gh)
test_torch.py::TestTorch::test_print
pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 2, 3, linux.2xlarge) (gh)
dynamo/cpython/3_13/test_set.py::TestSet::test_difference
pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 3, 3, linux.2xlarge) (gh)
test_module_tracker.py::TestModuleTracker::test_bw_detection
pull / linux-focal-py3.9-clang10 / test (default, 1, 5, linux.4xlarge) (gh)
dynamo/test_sets.py::TestSetMethods::test_set_inplace_binary_ops_SetSubclass_op_iand
pull / linux-focal-py3.9-clang10 / test (default, 2, 5, linux.4xlarge) (gh)
dynamo/test_misc.py::MiscTests::test_frozenset_torch_func_contains
pull / linux-focal-py3.9-clang10 / test (default, 3, 5, linux.4xlarge) (g 8000 h)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_set_update_dynamic_shapes
pull / linux-focal-py3.9-clang10 / test (default, 4, 5, linux.4xlarge) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_frozenset_torch_func_contains_dynamic_shapes
pull / linux-focal-py3.9-clang10 / test (default, 5, 5, linux.4xlarge) (gh)
dynamo/test_dicts.py::DictTests::test_builtin_or_with_invalid_types
pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 1, 3, linux.2xlarge) (gh)
test_torch.py::TestTorch::test_print
pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 3, 3, linux.2xlarge) (gh)
test_module_tracker.py::TestModuleTracker::test_bw_detection
pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, linux.4xlarge) (gh)
dynamo/test_sets.py::TestSetMethods::test_set_inplace_binary_ops_SetSubclass_op_iand
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, linux.4xlarge) (gh)
dynamo/test_dicts.py::DictTests::test_builtin_or_with_invalid_types
pull / linux-jammy-py3.10-clang15-asan / test (default, 3, 6, linux.4xlarge) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_set_update_dynamic_shapes
pull / linux-jammy-py3.10-clang15-asan / test (default, 4, 6, linux.4xlarge) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_frozenset_torch_func_contains_dynamic_shapes
pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, linux.4xlarge) (gh)
dynamo/test_functions.py::DefaultsTests::test_keyword
pull / linux-jammy-py3.9-gcc11 / test (default, 1, 5, linux.2xlarge) (gh)
dynamo/test_sets.py::TestSetMethods::test_set_inplace_binary_ops_SetSubclass_op_iand
pull / linux-jammy-py3.9-gcc11 / test (default, 2, 5, linux.2xlarge) (gh)
dynamo/test_functions.py::DefaultsTests::test_keyword
pull / linux-jammy-py3.9-gcc11 / test (default, 3, 5, linux.2xlarge) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_set_update_dynamic_shapes
pull / linux-jammy-py3.9-gcc11 / test (default, 4, 5, linux.2xlarge) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_frozenset_torch_func_contains_dynamic_shapes
pull / linux-jammy-py3.9-gcc11 / test (numpy_2_x, 1, 1, linux.2xlarge) (gh)
dynamo/test_functions.py::DefaultsTests::test_keyword

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx
inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx
inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx
inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
'Test'
inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
'Test'
inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx
inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu) (gh) (trunk failure)
distributed/test_dynamo_distributed.py::TestFakeDistributedSingleProc::test_hf_bert_ddp_aot_eager
inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
distributed/test_dynamo_distributed.py::TestFakeDistributedSingleProc::test_hf_bert_ddp_aot_eager
inductor / unit-test / cuda12.6-py3.12-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
distributed/test_dynamo_distributed.py::TestFakeDistributedSingleProc::test_hf_bert_ddp_aot_eager
inductor / unit-test / cuda12.6-py3.13-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
distributed/test_dynamo_distributed.py::TestFakeDistributedSingleProc::test_hf_bert_ddp_aot_eager

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / cuda12.4-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) (gh) (#149370)
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 3056cdf Pull Request resolved: #153553

github-actions · 2025-05-14T16:54:30Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]

ghstack-source-id: d121d3d Pull Request resolved: #153553

[ghstack-poisoned]

ghstack-source-id: 674c11f Pull Request resolved: #153553

[ghstack-poisoned]

ghstack-source-id: 6307327 Pull Request resolved: #153553

[ghstack-poisoned]

ghstack-source-id: 9d65c57 Pull Request resolved: #153553

[ghstack-poisoned]

ghstack-source-id: 0c5afb3 Pull Request resolved: #153553

[ghstack-poisoned]

ghstack-source-id: 7d3e4ae Pull Request resolved: #153553

Update

8b218a1

[ghstack-poisoned]

guilhermeleobas mentioned this pull request May 14, 2025

[Set] Add CPython set tests #150792

Closed

guilhermeleobas mentioned this pull request May 12, 2025

[Set] Handle exception in ConstantVariable operation #152987

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels May 14, 2025

guilhermeleobas added a commit that referenced this pull request May 14, 2025

[SetSubclass] [wip] Add support for user defined sets

310f99c

ghstack-source-id: 3056cdf Pull Request resolved: #153553

pytorchbot added the open source label May 14, 2025

Update

40a20d8

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request May 14, 2025

[SetSubclass] [wip] Add support for user defined sets

ed90caa

ghstack-source-id: d121d3d Pull Request resolved: #153553

Update

979a4a6

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request May 14, 2025

[SetSubclass] [wip] Add support for user defined sets

fc6640b

ghstack-source-id: 674c11f Pull Request resolved: #153553

Update

55fc909

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request May 15, 2025

[SetSubclass] [wip] Add support for user defined sets

11d2e22

ghstack-source-id: 6307327 Pull Request resolved: #153553

Update

4a9f50c

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request May 15, 2025

[SetSubclass] [wip] Add support for user defined sets

5712d27

ghstack-source-id: 9d65c57 Pull Request resolved: #153553

guilhermeleobas added a commit that referenced this pull request May 16, 2025

[SetSubclass] [wip] Add support for user defined sets

c476fa8

ghstack-source-id: 9d65c57 Pull Request resolved: #153553

Update

1017121

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request May 16, 2025

[SetSubclass] [wip] Add support for user defined sets

4a5b22e

ghstack-source-id: 0c5afb3 Pull Request resolved: #153553

Update

31a1eed

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request May 16, 2025

[SetSubclass] [wip] Add support for user defined sets

493bd87

ghstack-source-id: 7d3e4ae Pull Request resolved: #153553

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SetSubclass] [wip] Add support for user defined sets #153553

[SetSubclass] [wip] Add support for user defined sets #153553

[SetSubclass] [wip] Add support for user defined sets #153553

Are you sure you want to change the base?

[SetSubclass] [wip] Add support for user defined sets #153553

Conversation

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153553

❗ 1 Active SEVs

❌ 36 New Failures, 11 Unrelated Failures

This PR needs a release notes: label

This PR needs a `release notes:` label