8000 [Set] Raise `TypeError` if argument is unhashable by guilhermeleobas · Pull Request #152988 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Set] Raise TypeError if argument is unhashable #152988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

[Set] Raise TypeError if argument is unhashable #152988

wants to merge 16 commits into from

Conversation

guilhermeleobas
Copy link
Collaborator
@guilhermeleobas guilhermeleobas commented May 6, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@guilhermeleobas
Update
ad8d6a4 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152988

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3da5a81 with merge base 064f4c1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced May 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Draft
@guilhermeleobas
Update
9f901d6 
[ghstack-poisoned]
guilhermeleobas
guilhermeleobas commented May 7, 2025
View reviewed changes
torch/_dynamo/variables/dicts.py
@@ -127,7 +137,7 @@ def __init__(self, vt) -> None:
# TODO Temorarily remove to figure out what keys are we breaking on
# and add proper support for them
if not is_hashable(vt):
unimplemented(f"Dict key of type {type(vt)}. Key: {vt}")
raise_unhashable(vt)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes more sense to keep the code as it is (raise unimplemented). But this gives a chance for Dynamo to capture and handle an exception when one tries to add an unhashable object to a set. If Dynamo doesn't capture, the exception is propagated to CPython.

@guilhermeleobas guilhermeleobas marked this pull request as ready for review May 7, 2025 14:24
@guilhermeleobas
Update
3762786 
[ghstack-poisoned]
@guilhermeleobas
Update
567e6c6 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request May 7, 2025
Closed
@guilhermeleobas
Update
2310e43 
[ghstack-poisoned]
@guilhermeleobas
Update
a18cd11 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request May 8, 2025
Draft
@guilhermeleobas
Update
706c3ea 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas requested a review from StrongerXi May 8, 2025 18:37
@guilhermeleobas
Update
8c7b113 
[ghstack-poisoned]
@guilhermeleobas
Update
862dad2 
[ghstack-poisoned]
@guilhermeleobas
Update
8e16c94 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

@guilhermeleobas
Update
b60731c 
[ghstack-poisoned]
@guilhermeleobas
Update
0579bee 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request May 14, 2025
Draft
@guilhermeleobas
Update
4013025 
[ghstack-poisoned]
@guilhermeleobas
Update
8000
2171bbc 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

1 similar comment
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

@guilhermeleobas
Update
3da5a81 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152908

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise TypeError if number of arguments mismatch (#152904)
fe51ce6 
Pull Request resolved: #152904
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add set.symmetric_difference(_update) (#152901)
5926b7a 
Pull Request resolved: #152901
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add set.issubset and set.issuperset (#152902)
574f4c5 
Pull Request resolved: #152902
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise KeyError if elem not contained in the set (#152903)
5c6830c 
Pull Request resolved: #152903
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add set.difference(_update) (#152905)
ca96d55 
Pull Request resolved: #152905
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add set.intersection(_update) (#152906)
4759922 
Pull Request resolved: #152906
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Update set.union and set.update to support *args (#152989)
5964cb5 
Pull Request resolved: #152989
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise KeyError on empty set.pop() (#152907)
0530254 
Pull Request resolved: #152907
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906, #152989
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add correct set/frozenset __init__ behavior (#152908)
5a0ca65 
Pull Request resolved: #152908
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906, #152989, #152907
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise TypeError if set is called with the wrong number of argum…
f66a159 
…ents (#152990)

Pull Request resolved: #152990
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906, #152989, #152907, #152908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519

@StrongerXi StrongerXi Awaiting requested review from StrongerXi

Assignees
No one assigned
Labels
ciflow/inductor Merged module: dynamo open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guilhermeleobas @pytorchmergebot @anijain2305 @pytorchbot
0