8000 [Set] Add CPython set tests by guilhermeleobas · Pull Request #150792 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Set] Add CPython set tests #150792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 41 commits into from
Closed

[Set] Add CPython set tests #150792

wants to merge 41 commits into from

Conversation

guilhermeleobas
Copy link
Collaborator
@guilhermeleobas guilhermeleobas commented Apr 7, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Tests:

  • test_set.py

This PR adds test_set.py from the CPython 3.13 branch and ~400 files to test/dynamo_expected_failures. Most of these are expected to be fixed in upcoming PRs. Only minimal changes were made to test_set.py to enable compilation with Dynamo using the PYTORCH_TEST_WITH_DYNAMO=1 environment variable.

cc @albanD @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@guilhermeleobas
Update
583d87c 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150792

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5294bbb with merge base 064f4c1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Apr 7, 2025
Closed
Open
Open
Draft
Draft
Draft
Draft
Draft
Draft
Draft
@guilhermeleobas
Update
38e9a93 
[ghstack-poisoned]
@guilhermeleobas
Update
2053cb4 
[ghstack-poisoned]
@guilhermeleobas
Update
a272782 
[ghstack-poisoned]
@guilhermeleobas
Update
8000
8975b04 
[ghstack-poisoned]
@guilhermeleobas
Update
a41bbdc 
[ghstack-poisoned]
@guilhermeleobas
Update
fca42c1 
[ghstack-poisoned]
@guilhermeleobas
Update
3b646c7 
[ghstack-poisoned]
Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025
@guilhermeleobas
Add CPython set tests
7f31549 
Tests:
* test_set.py

ghstack-source-id: ae2723f
Pull Request resolved: pytorch/pytorch#150792
@guilhermeleobas
Update
b330c20 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request Apr 23, 2025
Open
@guilhermeleobas
Update
01086ec 
[ghstack-poisoned]
@guilhermeleobas
Update
a352b55 
[ghstack-poisoned]
@guilhermeleobas
Update
191a4a3 
[ghstack-poisoned]
@guilhermeleobas
Update
5b01bcb 
[ghstack-poisoned]
@guilhermeleobas
Update
8e5933b 
[ghstack-poisoned]
@guilhermeleobas
Copy link
Collaborator Author

@albanD, are you ok if I merge this one with the failing sanity check?

@guilhermeleobas
Copy link
Collaborator Author

This PR adds test_set.py from the CPython 3.13 branch and ~400 files to test/dynamo_expected_failures. Most of these are expected to be fixed in upcoming PRs. Only minimal changes were made to test_set.py to enable compilation with Dynamo using the PYTORCH_TEST_WITH_DYNAMO=1 environment variable.

To run the test, use:
python test/dynamo/cpython/3_13/test_set.py

@guilhermeleobas
Update
4fa6745 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request May 14, 2025
Draft
@guilhermeleobas
Update
69024dc 
[ghstack-poisoned]
@guilhermeleobas
Copy link
Collaborator Author

@albanD, I added a diff file, to which one can see the changes I made to the test_set.py file. To reproduce, one can run the following commands:

wget -O test/dynamo/cpython/3_13/test_set.py https://raw.githubusercontent.com/python/cpython/refs/heads/3.13/Lib/test/test_set.py
git apply test/dynamo/cpython/3_13/test_set.diff

These changes are required to run the test with Dynamo and pytest.

@albanD
Copy link
Collaborator
albanD commented May 14, 2025

Thanks for the details, skipping PR sanity check since this is auto-generated from cpython tests.

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

1 similar comment
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

@guilhermeleobas
Update
2ee9a77 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152908

@guilhermeleobas
Update
5294bbb 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator 8000

Starting merge as part of PR stack under #152990

pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Handle exception in ConstantVariable operation (#152987)
cf7021a 
Pull Request resolved: #152987
Approved by: https://github.com/williamwen42, https://github.com/anijain2305
ghstack dependencies: #150792
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise TypeError if argument is unhashable (#152988)
481c345 
Pull Request resolved: #152988
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise TypeError if number of arguments mismatch (#152904)
fe51ce6 
Pull Request resolved: #152904
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add set.symmetric_difference(_update) (#152901)
5926b7a 
Pull Request resolved: #152901
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add set.issubset and set.issuperset (#152902)
574f4c5 
Pull Request resolved: #152902
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise KeyError if elem not contained in the set (#152903)
5c6830c 
Pull Request resolved: #152903
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add set.difference(_update) (#152905)
ca96d55 
Pull Request resolved: #152905
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add set.intersection(_update) (#152906)
4759922 
Pull Request resolved: #152906
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Update set.union and set.update to support *args (#152989)
5964cb5 
Pull Request resolved: #152989
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise KeyError on empty set.pop() (#152907)
0530254 
Pull Request resolved: #152907
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906, #152989
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Add correct set/frozenset __init__ behavior (#152908)
5a0ca65 
Pull Request resolved: #152908
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906, #152989, #152907
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise TypeError if set is called with the wrong number of argum…
f66a159 
…ents (#152990)

Pull Request resolved: #152990
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906, #152989, #152907, #152908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519

@StrongerXi StrongerXi Awaiting requested review from StrongerXi

Assignees
No one assigned
Labels
ciflow/inductor Merged module: dynamo open source skip-pr-sanity-checks topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guilhermeleobas @albanD @pytorchmergebot @anijain2305 @pytorchbot
0