8000 [Set] Add correct set/frozenset __init__ behavior by guilhermeleobas · Pull Request #152908 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Set] Add correct set/frozenset __init__ behavior #152908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[Set] Add correct set/frozenset __init__ behavior #152908

wants to merge 19 commits into from

Conversation

guilhermeleobas
Copy link
Collaborator
@guilhermeleobas guilhermeleobas commented May 6, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@guilhermeleobas
Update
e91a6c5 
[ghstack-poisoned]
This was referenced May 6, 2025
Closed
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152908

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 2 Unrelated Failures

As of commit 2ed94b2 with merge base 064f4c1 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

8000 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guilhermeleobas guilhermeleobas mentioned this pull request May 6, 2025
Closed
This was referenced May 6, 2025
Closed
Closed
Closed
Closed
Closed
guilhermeleobas added a commit that referenced this pull request May 6, 2025
@guilhermeleobas
Add correct set/frozenset __init__ behavior
0bf6ae1 
ghstack-source-id: 434db11
Pull Request resolved: #152908
@guilhermeleobas
Update
124584f 
[ghstack-poisoned]
This was referenced May 6, 2025
Closed
Closed
Closed
@guilhermeleobas guilhermeleobas changed the title Add correct set/frozenset __init__ behavior [Set] Add correct set/frozenset __init__ behavior May 6, 2025
This was referenced May 6, 2025
Closed
Draft
@guilhermeleobas
Update
b2287fc 
[ghstack-poisoned]
@guilhermeleobas
Update
251dfbd 
[ghstack-poisoned]
@guilhermeleobas
Update
8d1106f 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request May 7, 2025
Closed
@guilhermeleobas
Update
e185479 
[ghstack-poisoned]
@guilhermeleobas
Update
41c8374 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request May 8, 2025
Draft
@guilhermeleobas
Update
169fcde 
[ghstack-poisoned]
@guilhermeleobas
Update
4167db5 
[ghstack-poisoned]
@guilhermeleobas
Update
6617c6f 
[ghstack-poisoned]
@guilhermeleobas
Update
8af320e 
[ghstack-poisoned]
@guilhermeleobas
Update
e883e6d 
[ghstack-poisoned]
@guilhermeleobas
Update
b5f2f68 
[ghstack-poisoned]
8000
@guilhermeleobas guilhermeleobas marked this pull request as ready for review May 12, 2025 17:02
@guilhermeleobas
Update
0bb2f61 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

@guilhermeleobas
Update
371d839 
[ghstack-poisoned]
@guilhermeleobas
Update
6c06640 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request May 14, 2025
Draft
@guilhermeleobas
Update
8e9e463 
[ghstack-poisoned]
@guilhermeleobas
Update
83f1e6c 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

1 similar comment
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

@guilhermeleobas
Update
2ed94b2 
[ghstack-poisoned]
@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #152990

pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@guilhermeleobas @pytorchmergebot
[Set] Raise TypeError if set is called with the wrong number of argum…
f66a159 
…ents (#152990)

Pull Request resolved: #152990
Approved by: https://github.com/anijain2305
ghstack dependencies: #150792, #152987, #152988, #152904, #152901, #152902, #152903, #152905, #152906, #152989, #152907, #152908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guilhermeleobas @pytorchmergebot @anijain2305 @pytorchbot
0