8000 Refactor `torch/utils/data/datapipes/gen_pyi.py` with `torchgen` by XuehaiPan · Pull Request #150626 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen #150626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 29 commits into from
Closed

Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen #150626

wants to merge 29 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Apr 3, 2025 •
edited
Loading

@XuehaiPan
Update
f45ecfe 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150626

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit c715b4f with merge base cb5f31a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Apr 3, 2025
This was referenced Apr 3, 2025
Closed
Closed
Closed
Closed
@XuehaiPan XuehaiPan added topic: not user facing topic category and removed release notes: dataloader release notes category labels Apr 3, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 3, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes with torchgen
e765275 
ghstack-source-id: 7778da7
Pull Request resolved: pytorch#150626
Skylion007
Skylion007 reviewed Apr 4, 2025
View reviewed changes
@XuehaiPan
Update
c5e71eb 
[ghstack-poisoned]
@XuehaiPan XuehaiPan changed the title Refactor torch/utils/data/datapipes with torchgen Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen Apr 4, 2025
XuehaiPan added 2 commits April 5, 2025 02:06
@XuehaiPan
Update
31693c5 
[ghstack-poisoned]
@XuehaiPan
Update
784096a 
[ghstack-poisoned]
@XuehaiPan XuehaiPan added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Apr 4, 2025
@XuehaiPan
Copy link
Collaborator Author

The gen_pyi.py file is not intended to export anything. Suppress the BC linter.

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 4, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
835868a 
ghstack-source-id: f92a3a2
Pull Request resolved: pytorch#150626
@XuehaiPan
Update
83dd5e4 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 4, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
b885a89 
ghstack-source-id: 909f4b3
Pull Request resolved: pytorch#150626
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 5, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
6807b5c 
ghstack-source-id: 909f4b3
Pull Request resolved: pytorch#150626
@XuehaiPan
Update
1e42449 
[ghstack-poisoned]
This was referenced Apr 5, 2025
Closed
Closed
Closed
Closed
Closed
@XuehaiPan
Update
307a025 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 10, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
c7971e7 
ghstack-source-id: a6f87a2
Pull Request resolved: pytorch#150626
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 11, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
f329296 
ghstack-source-id: a6f87a2
Pull Request resolved: pytorch#150626
@XuehaiPan
Update
421a151 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
deb2f45 
ghstack-source-id: c26fdb4
Pull Request resolved: pytorch#150626
@XuehaiPan
Update
0c6bcc3 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
0772019 
ghstack-source-id: da8ffa4
Pull Request resolved: pytorch#150626
aorenste
aorenste reviewed May 14, 2025
View reviewed changes
torch/utils/data/datapipes/gen_pyi.py Outdated
except ImportError:
import sys

REPO_ROOT = _Path(__file__).absolute().parents[4]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a quick comment saying when this is expected to occur?

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
51529d7 
ghstack-source-id: da8ffa4
Pull Request resolved: pytorch#150626
@XuehaiPan
Update
1476a20 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 15, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
d62d833 
ghstack-source-id: 4f83938
Pull Request resolved: pytorch#150626
@XuehaiPan XuehaiPan requested a review from aorenste May 15, 2025 15:18
@XuehaiPan
Update
6cec673 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 15, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
75de458 
ghstack-source-id: d469efd
Pull Request resolved: pytorch#150626
@XuehaiPan
Update
c715b4f 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 16, 2025
@XuehaiPan
Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen
3da2770 
ghstack-source-id: 0b4fbf3
Pull Request resolved: pytorch#150626
aorenste
aorenste approved these changes May 16, 2025
View reviewed changes
torch/utils/data/datapipes/gen_pyi.py
__all__: list[str] = [] # not intended to expose any symbols


def __dir__() -> list[str]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this appease the public API test? I'm surprised that the test treats a module with no actually visible members any different than one with and empty '__all__' defined... I wonder if there's a test bug there...

Copy link
Collaborator Author
@XuehaiPan XuehaiPan May 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public API test checks symbols in set(dir(mod)) - set(mod.__all__).

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@aorenste aorenste aorenste approved these changes

@divyanshk divyanshk Awaiting requested review from divyanshk divyanshk is a code owner

@ramanishsingh ramanishsingh Awaiting requested review from ramanishsingh ramanishsingh is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuehaiPan @pytorchmergebot @Skylion007 @aorenste @pytorchbot
0