8000 [BE] Add `__all__` to `torch/nn/functional.pyi` and `torch/return_types.pyi` by XuehaiPan · Pull Request #150729 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE] Add __all__ to torch/nn/functional.pyi and torch/return_types.pyi #150729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

[BE] Add __all__ to torch/nn/functional.pyi and torch/return_types.pyi #150729

wants to merge 22 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Apr 5, 2025 •
edited
Loading

@XuehaiPan
Update
3ff03cf 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150729

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bbb0a1a with merge base e5e06d9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Apr 5, 2025
Closed
Closed
Closed
Closed
Closed
Open
Open
@XuehaiPan XuehaiPan added module: nn Related to torch.nn better-engineering Relatively self-contained tasks for better engineering contributors module: codegen Issues related to the codegen for Aten and Autograd topic: not user facing topic category labels Apr 5, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 5, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
adbb0cf 
…es.pyi`

ghstack-source-id: d1097be
Pull Request resolved: pytorch#150729
XuehaiPan added 2 commits April 5, 2025 16:09
@XuehaiPan
Update
6e89288 
[ghstack-poisoned]
@XuehaiPan
Update
8e116b4 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from Copilot April 5, 2025 08:25
Copilot
Copilot AI reviewed Apr 5, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • torch/_C/return_types.pyi.in: Language not supported
  • torch/nn/functional.pyi.in: Language not supported
Comments suppressed due to low confidence (2)

tools/pyi/gen_pyi.py:605

  • Consider explicitly using unsorted_dispatched_hints.keys() when extending extra_nn_functional___all__ to make it clear that the keys are being added.
extra_nn_functional___all__.extend(unsorted_dispatched_hints)

tools/pyi/gen_pyi.py:558

  • [nitpick] Consider adding a brief comment explaining why 'log_sigmoid' is renamed to 'logsigmoid' to improve code readability.
renamed = {"log_sigmoid": "logsigmoid"}

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 5, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
2a0e247 
…es.pyi`

ghstack-source-id: d8e7ebd
Pull Request resolved: pytorch#150729
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 5, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
1da6b31 
…es.pyi`

ghstack-source-id: d8e7ebd
Pull Request resolved: pytorch#150729
@XuehaiPan
Update
87c865e 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/XuehaiPan/269/orig onto refs/remotes/origin/viable/strict because #150732 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/150729)

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 7, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
8ad8959 
…es.pyi`

ghstack-source-id: e6f7fe5
Pull Request resolved: pytorch#150729
@albanD albanD removed their request for review April 7, 2025 19:20
@XuehaiPan
Update
41145fc 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/XuehaiPan/269/orig onto refs/remotes/origin/viable/strict because #150732 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/150729)

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
bf879a4 
…es.pyi`

ghstack-source-id: 71d621f
Pull Request resolved: pytorch#150729
@XuehaiPan
Update
34abb77 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
87f93cc 
…es.pyi`

ghstack-source-id: b1807a7
Pull Request resolved: pytorch#150729
@XuehaiPan
Update
e44ca1b 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
006c64a 
…es.pyi`

ghstack-source-id: 3223b54
Pull Request resolved: pytorch#150729
@XuehaiPan
Update
93cb9c9 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 10, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
a45aa26 
…es.pyi`

ghstack-source-id: 144d3aa
Pull Request resolved: pytorch#150729
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 11, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
63f26ba 
…es.pyi`

ghstack-source-id: 144d3aa
Pull Request resolved: pytorch#150729
@XuehaiPan
Update
30ec5f2 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
f54988b 
…es.pyi`

ghstack-source-id: be693b5
Pull Request resolved: pytorch#150729
@XuehaiPan
Update
e4a73ee 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
eddc5ac 
…es.pyi`

ghstack-source-id: 1663c9e
Pull Request resolved: pytorch#150729
aorenste
aorenste approved these changes May 14, 2025
View reviewed changes
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
b47444a 
…es.pyi`

ghstack-source-id: 1663c9e
Pull Request resolved: pytorch#150729
@XuehaiPan
Update
bbb0a1a 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 15, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 15, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
536a81b 
…es.pyi`

ghstack-source-id: 3f281ef
Pull Request resolved: pytorch#150729
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / build, trunk / win-vs2022-cuda12.6-py3 / build

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 15, 2025
@XuehaiPan
[BE] Add __all__ to torch/nn/functional.pyi and `torch/return_typ…
6822db1 
…es.pyi`

ghstack-source-id: 3f281ef
Pull Request resolved: pytorch#150729
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@aorenste aorenste aorenste approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged module: codegen Issues related to the codegen for Aten and Autograd module: nn Related to torch.nn open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @pytorchmergebot @aorenste @pytorchbot
0