8000 [BE] Ensure generated stub files by `gen_pyi` are properly formatted by XuehaiPan · Pull Request #150730 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE] Ensure generated stub files by gen_pyi are properly formatted #150730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: gh/XuehaiPan/267/base
Choose a base branch
from
Open

[BE] Ensure generated stub files by gen_pyi are properly formatted #150730

wants to merge 27 commits into from
+84 −31

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Apr 5, 2025 •
edited
Loading

@XuehaiPan
Update
7c8e0b8 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150730

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 1 Pending

As of commit 08cb6a3 with merge base 9b2a45a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Apr 5, 2025
Closed
Closed
Closed
Closed
Closed
Open
Open
@XuehaiPan XuehaiPan added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Apr 5, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 5, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
135ddc9 
ghstack-source-id: 5760db7
Pull Request resolved: pytorch#150730
XuehaiPan added 3 commits April 5, 2025 16:09
@XuehaiPan
Update
4bb18eb 
[ghstack-poisoned]
@XuehaiPan
Update
709688b 
[ghstack-poisoned]
@XuehaiPan
Update
f6dda3b 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 5, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
a8f5dd6 
ghstack-source-id: f06f854
Pull Request resolved: pytorch#150730
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 5, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
e5f5882 
ghstack-source-id: f06f854
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
69f87fd 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/XuehaiPan/269/orig onto refs/remotes/origin/viable/strict because #150732 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/150730)

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 7, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
f94e288 
ghstack-source-id: 8840dda
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
c2a6936 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/XuehaiPan/269/orig onto refs/remotes/origin/viable/strict because #150732 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/150730)

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #150732

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 9, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
41a4a8c 
ghstack-source-id: 8840dda
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
69bec63 
[ghstack-poisoned]
@XuehaiPan
Update
7cebd8e 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 14, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
32c5a8b 
ghstack-source-id: a7ca769
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
a57c97b 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 14, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
46e88a4 
ghstack-source-id: 6e85f11
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
88f5f6a 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
944e53b 
ghstack-source-id: e37c460
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
f7773be 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
ad183dd 
ghstack-source-id: 0f3cfdf
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
dd302dc 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 10, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
83c8b82 
ghstack-source-id: b23cfe8
Pull Request resolved: pytorch#150730
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 11, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
689fde4 
ghstack-source-id: b23cfe8
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
5ae4558 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
a818a37 
ghstack-source-id: d4c7d04
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
2a0aadf 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
027d340 
ghstack-source-id: aba4321
Pull Request resolved: pytorch#150730
aorenste
aorenste approved these changes May 14, 2025
View reviewed changes
tools/pyi/gen_pyi.py
if name.startswith("i"):
# In-place binary-operation dunder methods, like `__iadd__`, should return `Self`
return [
f"def {opname}(self, other: Tensor | Number | _complex) -> Tensor: ... # noqa: PYI034"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not return Self? BC or doesn't match actual behavior?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not match the actual behavior because the in-place operation might promote the dtype.

@XuehaiPan
Update
3dcb188 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
d439be5 
ghstack-source-id: 7deb6cc
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
1204e8f 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 15, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
79503c6 
ghstack-source-id: b4010b3
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
fb1848d 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 15, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
c19a8d1 
ghstack-source-id: d17ed41
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
036fe0a 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 16, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
a4656f4 
ghstack-source-id: 95d223a
Pull Request resolved: pytorch#150730
@XuehaiPan
Update
08cb6a3 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 17, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
f9d2ab4 
ghstack-source-id: 5142745
Pull Request resolved: pytorch#150730
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 17, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 17, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
47ab318 
ghstack-source-id: 5142745
Pull Request resolved: pytorch#150730
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 17, 2025
@XuehaiPan
[BE] Ensure generated stub files by gen_pyi are properly formatted
81CC
74c8be5 
ghstack-source-id: 5142745
Pull Request resolved: pytorch#150730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aorenste aorenste aorenste approved these changes

@divyanshk divyanshk Awaiting requested review from divyanshk

@ramanishsingh ramanishsingh Awaiting requested review from ramanishsingh

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request merging open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @pytorchmergebot @aorenste @pytorchbot
0