[CI] Run lintrunner on generated .pyi stub files in CI
#129887
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 1, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129887
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 818450e with merge base 09c4da9 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 1, 2024
@ezyang How about raising warnings rather than errors for these files? See my comment at #129420 (comment). |
lintrunner on generated .pyi stub fileslintrunner on generated .pyi stub files
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Mar 16, 2025
ghstack-source-id: d78a77f Pull Request resolved: pytorch#129887
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 3, 2025
ghstack-source-id: 934e29f Pull Request resolved: pytorch#129887
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 5, 2025
ghstack-source-id: 767f5b1 Pull Request resolved: pytorch#129887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #129420 (comment), this PR is aimed at preventing potential typing errors in the future.
I have fixed all lint errors on the current generated
.pyistub files.Stack from ghstack (oldest at bottom):
lintrunneron generated.pyistub files in CI #129887torch/utils/data/datapipes/gen_pyi.pywithtorchgen#150626__all__totorch/nn/functional.pyiandtorch/return_types.pyi#129872.pyistub files #129420torchgen.utils.FileManagerto acceptpathlib.Path#129871cc @ezyang @malfet @xuzhao9 @gramster @seemethere @pytorch/pytorch-dev-infra