8000 [BE][Easy] Fix `PYI034`: non-self-return-type in tensor method hints by XuehaiPan · Pull Request #129886 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints #129886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints #129886

wants to merge 35 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Jul 1, 2024 •
edited
Loading

In gen_pyi.py, we add generated method hints for dunder magic methods for class TensorBase at:

pytorch/torch/_C/__init__.pyi.in

Line 1734 in 8c2c3a0

${tensor_method_hints}

such as:

class TensorBase:
    @overload
    def __add__(self, other: Tensor) -> Tensor: ...
    @overload
    def __add__(self, other: Union[Number, _complex]) -> Tensor: ...
    @overload
    def __add__(self, other: Any) -> Tensor: ...
    @overload
    def __iadd__(self, other: Tensor) -> Tensor: ...
    @overload
    def __iadd__(self, other: Union[Number, _complex]) -> Tensor: ...
    @overload
    def __iadd__(self, other: Any) -> Tensor: ...

This PR changes the return type of in-place binary operations (e.g. __iadd__, __imul__, ...) from Tensor to Self to fix non-self-return-type (PYI034).

class TensorBase:
    @overload
    def __add__(self, other: Tensor) -> Tensor: ...
    @overload
    def __add__(self, other: Union[Number, _complex]) -> Tensor: ...
    @overload
    def __add__(self, other: Any) -> Tensor: ...
    @overload
    def __iadd__(self, other: Tensor) -> Self: ...
    @overload
    def __iadd__(self, other: Union[Number, _complex]) -> Self: ...
    @overload
    def __iadd__(self, other: Any) -> Self: ...

Stack from ghstack (oldest at bottom):

cc @ezyang @malfet @xuzhao9 @gramster

@XuehaiPan
Update
4612e4d 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 1, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jul 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129886

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit f31f883 with merge base ffb9790 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 1, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@XuehaiPan
Update
0ec60d8 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jul 1, 2024
Closed
@XuehaiPan
Update
c047c95 
[ghstack-poisoned]
@XuehaiPan XuehaiPan added the module: typing Related to mypy type annotations label Jul 1, 2024
@XuehaiPan XuehaiPan requested a review from Skylion007 July 1, 2024 18:29
XuehaiPan added 2 commits July 2, 2024 02:30
@XuehaiPan
Update
ccf219c 
[ghstack-poisoned]
@XuehaiPan
Update 8000
8ef2de5 
[ghstack-poisoned]
XuehaiPan added 2 commits July 2, 2024 03:17
@XuehaiPan
Update
ebe382a 
[ghstack-poisoned]
@XuehaiPan
Update
1664990 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jul 1, 2024
Closed
@XuehaiPan
Update
c4e1c20 
[ghstack-poisoned]
malfet
malfet requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be frank, I'm quite at loss if how PR title connected to any of the changes you are proposing here

@XuehaiPan
Copy link
Collaborator Author

To be frank, I'm quite at loss if how PR title connected to any of the changes you are proposing here

Sorry, I have updated the PR comment for what this PR is doing.

@XuehaiPan
Update
9179196 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 20, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
112127c 
ghstack-source-id: 1db440b
Pull Request resolved: pytorch#129886
@XuehaiPan
Update
88ee3c3 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 1, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
fcb246f 
ghstack-source-id: 5074a89
Pull Request resolved: pytorch#129886
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 2, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
b88ac9e 
ghstack-source-id: 5074a89
Pull Request resolved: pytorch#129886
@XuehaiPan
Update
6d4f76a 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 2, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
6f37ecb 
ghstack-source-id: cb015e7
Pull Request resolved: pytorch#129886
@XuehaiPan
Update
9ad387c 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 3, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
3b260b7 
ghstack-source-id: 1765f68
Pull Request resolved: pytorch#129886
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 3, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
baf5bb1 
ghstack-source-id: 1765f68
Pull Request resolved: pytorch#129886
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 4, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
5e67504 
ghstack-source-id: 1765f68
Pull Request resolved: pytorch#129886
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 4, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
00d8189 
ghstack-source-id: 1765f68
Pull Request resolved: pytorch#129886
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 4, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
0d83d23 
ghstack-source-id: 1765f68
Pull Request resolved: pytorch#129886
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 12, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
7503968 
ghstack-source-id: 1765f68
Pull Request resolved: pytorch#129886
@XuehaiPan
Update
59aa8f2 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 12, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
eaf296b 
ghstack-source-id: 1f9c3f3
Pull Request resolved: pytorch#129886
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 11, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
ab4701e 
ghstack-source-id: 1f9c3f3
Pull Request resolved: pytorch#129886
@XuehaiPan
Update
9eeaae6 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 11, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
4aeee41 
ghstack-source-id: b8ad561
Pull Request resolved: pytorch#129886
@XuehaiPan
Update
8a72aba 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 11, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
9cca273 
ghstack-source-id: 115ee85
Pull Request resolved: pytorch#129886
@XuehaiPan
Update
cd24049 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 24, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
15bc35b 
ghstack-source-id: 9326463
Pull Request resolved: pytorch#129886
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 24, 2024
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
f237c31 
ghstack-source-id: 9326463
Pull Request resolved: pytorch#129886
@XuehaiPan
Update
f31f883 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Nov 11, 2024 6D40
@XuehaiPan
[BE][Easy] Fix PYI034: non-self-return-type in tensor method hints
d7c5cf3 
ghstack-source-id: 622e182
Pull Request resolved: pytorch#129886
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jan 10, 2025
@github-actions github-actions bot closed this Feb 9, 2025
@github-actions github-actions bot deleted the gh/XuehaiPan/104/head branch March 12, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
module: typing Related to mypy type annotations open source Stale topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuehaiPan @malfet @pytorchbot
0