8000 [BE][Easy] Fix `PYI001`: unprefixed-type-param in `torch/utils/data/datapipes` by XuehaiPan · Pull Request #129885 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE][Easy] Fix PYI001: unprefixed-type-param in torch/utils/data/datapipes #129885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

[BE][Easy] Fix PYI001: unprefixed-type-param in torch/utils/data/datapipes #129885

wants to merge 14 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Jul 1, 2024 •
edited by pytorch-bot bot
Loading

@XuehaiPan
Update
bf5b919 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jul 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129885

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f3035d4 with merge base 3c6c3b9 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Jul 1, 2024
This was referenced Jul 1, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@XuehaiPan
Update
6b92950 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jul 1, 2024
Closed
@XuehaiPan
Update
b18a0ae 
[ghstack-poisoned]
@XuehaiPan XuehaiPan added module: typing Related to mypy type annotations topic: not user facing topic category labels Jul 1, 2024
@XuehaiPan XuehaiPan requested a review from Skylion007 July 1, 2024 18:28
XuehaiPan added 2 commits July 2, 2024 02:30
@XuehaiPan
Update
e3c1025 
[ghstack-poisoned]
@XuehaiPan
Update
c2ef81d 
[ghstack-poisoned]
XuehaiPan added 2 commits July 2, 2024 03:17
@XuehaiPan
Update
98066ac 
[ghstack-poisoned]
@XuehaiPan
Update
700d6af 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jul 1, 2024
Closed
@XuehaiPan
Update
33154b6 
[ghstack-poisoned]
@XuehaiPan
Update
9829239 
[ghstack-poisoned]
@XuehaiPan
Update
35945bf 
[ghstack-poisoned]
Update
f3035d4 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 2, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@XuehaiPan XuehaiPan added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Jul 2, 2024
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@gokulavasan gokulavasan mentioned this pull request Jul 3, 2024
Merged
@kit1980
Copy link
Contributor
kit1980 commented Jul 4, 2024

This was reverted internally for breaking stateful dataloader, but that was already fixed in pytorch/data#1282

I will look on Friday how to proceed best, I'd prefer not reverting this PR and re-land it internally.

cc @gokulavasan

@kit1980 kit1980 added module: bc-breaking Related to a BC-breaking change topic: bc breaking topic category labels Jul 5, 2024
@kit1980
Copy link
Contributor
kit1980 commented Jul 5, 2024

Internal breakages are being fixed internally.
But strictly speaking removal of T_co is backward compatibility breaking, should be marked as such, and we need to be careful with such changes.

@github-actions github-actions bot deleted the gh/XuehaiPan/103/head branch August 5, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@andrewkho andrewkho Awaiting requested review from andrewkho

@gokulavasan gokulavasan Awaiting requested review from gokulavasan

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: bc-breaking Related to a BC-breaking change module: typing Related to mypy type annotations open source release notes: dataloader release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc breaking topic category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuehaiPan @pytorchmergebot @kit1980 @ezyang @pytorchbot
0