8000 gh-117431: Adapt str.{start,end}swith to use the METH_FASTCALL calling convention by erlend-aasland · Pull Request #117466 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117431: Adapt str.{start,end}swith to use the METH_FASTCALL calling convention #117466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 3, 2024
Merged

gh-117431: Adapt str.{start,end}swith to use the METH_FASTCALL calling convention #117466

merged 6 commits into from
Apr 3, 2024

Conversation

erlend-aasland
Copy link
Contributor
@erlend-aasland erlend-aasland commented Apr 2, 2024 •
edited by bedevere-app bot
Loading

@erlend-aasland
Copy link
Contributor Author

cc. faster-cpython/ideas#671

@erlend-aasland erlend-aasland changed the title Draft: adapt str.{start,end}swith to Argument Clinic gh-117431: Adapt str.{start,end}swith to use the METH_FASTCALL calling convention Apr 2, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 2, 2024
Open
@erlend-aasland erlend-aasland marked this pull request as ready for review April 2, 2024 15:37
@erlend-aasland
8000 Copy link
Contributor Author 
# main
$ ./python.exe -m timeit -s "s = 'abcdef'" "s.startswith('abc')"
5000000 loops, best of 5: 89.1 nsec per loop

# this PR
$ ./python.exe -m timeit -s "s = 'abcdef'" "s.startswith('abc')"
10000000 loops, best of 5: 26.4 nsec per loop

@erlend-aasland erlend-aasland mentioned this pull request Apr 2, 2024
Open
eendebakpt
eendebakpt reviewed Apr 2, 2024
View reviewed changes
@erlend-aasland
Copy link
Contributor Author
erlend-aasland commented Apr 2, 2024 •
edited
Loading

We'll also want to convert str.find and friend and finally get rid of the parsing helper in strlib. However, that is best left to a follow-up PR (#117468). I prefer small and incremental changes.

@eendebakpt eendebakpt mentioned this pull request Apr 2, 2024
Closed
JelleZijlstra
JelleZijlstra reviewed Apr 2, 2024
View reviewed changes
@eendebakpt eendebakpt mentioned this pull request Apr 2, 2024
Closed
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, @JelleZijlstra and @eendebakpt. I'll hold off merging for a day or two.

@erlend-aasland
Copy link
Contributor Author
erlend-aasland commented Apr 3, 2024 •
edited
Loading

Well, with two core devs approving, I'll go ahead and merge. Thanks for the reviews.

@erlend-aasland erlend-aasland merged commit 444156e into python:main Apr 3, 2024
@erlend-aasland erlend-aasland deleted the perf/starwith branch April 3, 2024 07:11
methane
methane reviewed Apr 3, 2024
View reviewed changes
8000
@erlend-aasland erlend-aasland mentioned this pull request Apr 3, 2024
Merged
@vstinner
Copy link
Member
vstinner commented Apr 4, 2024

Nice optimization!

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117431: Adapt str.startswith and str.endswith to Argument Cl…
65e6c41 
…inic (python#117466)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@eendebakpt eendebakpt eendebakpt left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @vstinner @methane @eendebakpt @JelleZijlstra
0