8000 Improve performance of startswith, endswith, count, *find, and *index methods for str, bytes and bytearray · Issue #117431 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Improve performance of startswith, endswith, count, *find, and *index methods for str, bytes and bytearray #117431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eendebakpt opened this issue Apr 1, 2024 · 3 comments
Open

Improve performance of startswith, endswith, count, *find, and *index methods for str, bytes and bytearray #117431

eendebakpt opened this issue Apr 1, 2024 · 3 comments
Labels
3.13 bugs and security fixes performance Performance or resource usage type-feature A feature request or enhancement

Comments

@eendebakpt
Copy link
Contributor
eendebakpt commented Apr 1, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

We can improve performance of str.startswith and other methods for the single-argument case by creating a fast path in the single argument parsing.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

faster-cpython/ideas#671

Linked PRs
@eendebakpt eendebakpt added the type-feature A feature request or enhancement label Apr 1, 2024
@Eclips4 Eclips4 added the performance Performance or resource usage label Apr 1, 2024
@AlexWaygood AlexWaygood added the 3.13 bugs and security fixes label Apr 1, 2024
This was referenced Apr 1, 2024
Closed
Merged
Merged
@eendebakpt

This comment was marked as off-topic.

Sign in to view
@bedevere-app bedevere-app bot mentioned this issue Apr 2, 2024
Closed
erlend-aasland added a commit that referenced this issue Apr 3, 2024
@erlend-aasland
gh-117431: Adapt str.startswith and str.endswith to Argument Clinic (#…
444156e 
…117466)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used.
@bedevere-app bedevere-app bot mentioned this issue Apr 3, 2024
Merged
@erlend-aasland erlend-aasland changed the title Improve performance of startswith and endswith methods for str and bytes Improve performance of startswith, endswith, count, *find, and *index methods for str, bytes and bytearray Apr 3, 2024
@erlend-aasland
Copy link
Contributor

Conversion of bytes/bytearray find() and friends1 is not straight-forward: the first argument can be either a buffer or an index in the range [0,255]. The code is shared between bytes and bytearray2. My first thought would be to create a custom Argument Clinic converter3, but we'd want that also to be shared between bytes and bytearray.

Footnotes

  1. rfind, index, rindex, count ↩

  2. Objects/bytes_methods.c ↩

  3. a combination of one Argument Clinic Python input block and one C function ↩

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Apr 3, 2024
@erlend-aasland
pythongh-117431: Fix str.endswith docstring
34157dc 
The first parameter is named 'suffix', not 'prefix'.

Regression introduced by commit 444156e
@bedevere-app bedevere-app bot mentioned this issue Apr 3, 2024
Merged
erlend-aasland added a commit that referenced this issue Apr 3, 2024
@erlend-aasland
gh-117431: Fix str.endswith docstring (#117499)
1dc1521 
The first parameter is named 'suffix', not 'prefix'.

Regression introduced by commit 444156e
erlend-aasland added a commit that referenced this issue Apr 3, 2024
@erlend-aasland
gh-117431: Adapt bytes and bytearray .startswith() and .endswith() to…
595bb49 
… Argument Clinic (#117495)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used.
@bedevere-app bedevere-app bot mentioned this issue Apr 3, 2024
Merged
erlend-aasland added a commit that referenced this issue Apr 3, 2024
@erlend-aasland
gh-117431: Adapt str.find and friends to Argument Clinic (#117468)
7ecd55d 
This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used. The following methods are adapted:

- str.count
- str.find
- str.index
- str.rfind
- str.rindex
@hugovk
Copy link
Member
hugovk commented Apr 3, 2024

Nice work so far! Would be good to put these in What's New, perhaps under https://docs.python.org/3.13/whatsnew/3.13.html#optimizations.

Can be done later, when closing the issue.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Apr 6, 2024
@erlend-aasland
pythongh-117431: Amend str method signatures after PR python#117468
5ea33ed
This was referenced Apr 6, 2024
Closed
Merged
erlend-aasland added a commit that referenced this issue Apr 10, 2024
@erlend-aasland
gh-117431: Argument Clinic: copy forced text signature when cloning (#…
0d42ac9 
…117591)
@bedevere-app bedevere-app bot mentioned this issue Apr 11, 2024
Open
erlend-aasland added a commit that referenced this issue Apr 12, 2024
@erlend-aasland @methane
gh-117431: Adapt bytes and bytearray .find() and friends to Argument …
deb921f 
…Clinic (#117502)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used. The following bytes and bytearray methods are adapted:

- count()
- find()
- index()
- rfind()
- rindex()

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117431: Adapt str.startswith and str.endswith to Argument Cl…
65e6c41 
…inic (python#117466)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used.
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117431: Fix str.endswith docstring (python#117499)
171b65d 
The first parameter is named 'suffix', not 'prefix'.

Regression introduced by commit 444156e
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117431: Adapt bytes and bytearray .startswith() and .endswit…
becac00 
…h() to Argument Clinic (python#117495)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used.
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117431: Adapt str.find and friends to Argument Clinic (pytho…
4bed8cd 
…n#117468)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used. The following methods are adapted:

- str.count
- str.find
- str.index
- str.rfind
- str.rindex
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117431: Argument Clinic: copy forced text signature when clo…
c8f5d96 
…ning (python#117591)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @methane @diegorusso
pythongh-117431: Adapt bytes and bytearray .find() and friends to Arg…
12e5501 
…ument Clinic (python#117502)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used. The following bytes and bytearray methods are adapted:

- count()
- find()
- index()
- rfind()
- rindex()

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes performance Performance or resource usage type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@eendebakpt @hugovk @erlend-aasland @AlexWaygood @Eclips4
0