8000 gh-117431: Argument Clinic: copy forced text signature when cloning by erlend-aasland · Pull Request #117591 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117431: Argument Clinic: copy forced text signature when cloning #117591

New 8000 issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 10, 2024
Merged

gh-117431: Argument Clinic: copy forced text signature when cloning #117591

merged 6 commits into from
Apr 10, 2024

Conversation

erlend-aasland
Copy link
Contributor
@erlend-aasland erlend-aasland commented Apr 6, 2024 •
edited by bedevere-app bot
Loading

@erlend-aasland erlend-aasland changed the title Argument Clinic: copy forced text signature when cloning gh-117431: Argument Clinic: copy forced text signature when cloning Apr 6, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 6, 2024
Open
@erlend-aasland erlend-aasland marked this pull request as ready for review April 6, 2024 20:46
vstinner
vstinner approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can ignore my suggestion on using a non-empty docstring.

serhiy-storchaka
serhiy-storchaka reviewed Apr 9, 2024
View reviewed changes
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, @vstinner. I expanded the tests.

@erlend-aasland erlend-aasland requested a review from vstinner April 9, 2024 21:21
serhiy-storchaka
serhiy-storchaka approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Serhiy! I'll land this tomorrow.

@erlend-aasland erlend-aasland mentioned this pull request Apr 9, 2024
Closed
@erlend-aasland erlend-aasland merged commit 0d42ac9 into python:main Apr 10, 2024
@erlend-aasland erlend-aasland deleted the clinic/clone-text-signature branch April 10, 2024 08:12
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117431: Argument Clinic: copy forced text signature when clo…
c8f5d96 
…ning (python#117591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @vstinner @serhiy-storchaka
0