8000 gh-117431: Adapt str.find and friends to use the METH_FASTCALL calling convention by erlend-aasland · Pull Request #117468 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117431: Adapt str.find and friends to use the METH_FASTCALL calling convention #117468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 3, 2024
Merged

gh-117431: Adapt str.find and friends to use the METH_FASTCALL calling convention #117468

merged 20 commits into from
Apr 3, 2024

Conversation

@erlend-aasland
Copy link
Contributor
@erlend-aasland erlend-aasland commented Apr 2, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 2, 2024
Open
@erlend-aasland erlend-aasland mentioned this pull request Apr 2, 2024
Merged
@erlend-aasland erlend-aasland marked this pull request as ready for review April 3, 2024 07:15
@erlend-aasland
Copy link
Contributor Author
erlend-aasland commented Apr 3, 2024

Similar speedsups as with str.startswith and str.endswith:

# main
$ ./python.exe -m timeit -s "s = 'abcdef'" "s.count('a')"
5000000 loops, best of 5: 92.5 nsec per loop

# This PR
$ ./python.exe -m timeit -s "s = 'abcdef'" "s.count('a')"
10000000 loops, best of 5: 26.2 nsec per loop

@erlend-aasland erlend-aasland mentioned this pull request Apr 3, 2024
Merged
@erlend-aasland
Copy link
Contributor Author
erlend-aasland commented Apr 3, 2024

Thanks for the review, Inada-san.

@erlend-aasland erlend-aasland merged commit 7ecd55d into python:main Apr 3, 2024
@erlend-aasland erlend-aasland deleted the perf/str.find-and-friends branch April 3, 2024 15:59
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Apr 6, 2024
@erlend-aasland
pythongh-117431: Amend str method signatures after PR python#117468
5ea33ed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-117431: Adapt str.find and friends to Argument Clinic (pytho…
4bed8cd 
…n#117468)

This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used. The following methods are adapted:

- str.count
- str.find
- str.index
- str.rfind
- str.rindex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@methane methane methane approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland @methane @Eclips4
0