8000 gh-117431: Adapt str.{start,end}swith to use the METH_FASTCALL calling convention by erlend-aasland · Pull Request #117466 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117431: Adapt str.{start,end}swith to use the METH_FASTCALL calling convention #117466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2024
Merged

gh-117431: Adapt str.{start,end}swith to use the METH_FASTCALL calling convention #117466

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c038634
Draft: adapt str.{start,end}swith to Argument Clinic
erlend-aasland Apr 2, 2024
a9d3172
Revert unneeded and malformed change
erlend-aasland Apr 2, 2024
2ce5be6
Loosen error message tests
erlend-aasland Apr 2, 2024
6c95a0d
NEWS
erlend-aasland Apr 2, 2024
8fe04ae
Fixup endswith signature
erlend-aasland Apr 2, 2024
c2ce49e
Address Jelle's review: clarify default values in param docstrings
erlend-aasland Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
< 8000 /details-menu>
Diff view
Diff view
Prev Previous commit
Next Next commit
Loosen error message tests
  • Loading branch information
@erlend-aasland
erlend-aasland committed Apr 2, 2024
commit 2ce5be63844534f362476cf183ba8f38950acea3
4 changes: 2 additions & 2 deletions Lib/test/string_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,9 +1513,9 @@ def test_find_etc_raise_correct_error_messages(self):
x, None, None, None)
self.assertRaisesRegex(TypeError, r'^count\(', s.count,
x, None, None, None)
self.assertRaisesRegex(TypeError, r'^startswith\(', s.startswith,
self.assertRaisesRegex(TypeError, r'^startswith\b', s.startswith,
x, None, None, None)
self.assertRaisesRegex(TypeError, r'^endswith\(', s.endswith,
self.assertRaisesRegex(TypeError, r'^endswith\b', s.endswith,
x, None, None, None)

# issue #15534
Expand Down
0