(fix) change log level to warn when experiment not in datafile #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajw015
approved these changes
Feb 26, 2020
alanhuu
approved these changes
Feb 26, 2020
606aa49 to
0d6976d
Compare
Pull Request Test Coverage Report for Build 1363
💛 - Coveralls |
circAssimilate
pushed a commit
to optimizely/javascript-sdk
that referenced
this pull request
Mar 3, 2020
… event In a similar vein as optimizely/java-sdk#361, the JavaScript SDK would be less noisy when being used with integrations like Segment if we only logged a warning when an event key is not found in the datafile. This PR will make that change and unblock event tracking.
circAssimilate
pushed a commit
to optimizely/javascript-sdk
that referenced
this pull request
Mar 3, 2020
… event In a similar vein as optimizely/java-sdk#361, the JavaScript SDK would be less noisy when being used with integrations like Segment if we only logged a warning when an event key is not found in the datafile. This PR will make that change and unblock event tracking.
circAssimilate
pushed a commit
to optimizely/javascript-sdk
that referenced
this pull request
Mar 3, 2020
… event In a similar vein as optimizely/java-sdk#361, the JavaScript SDK would be less noisy when being used with integrations like Segment if we only logged a warning when an event key is not found in the datafile. This PR will make that change and unblock event tracking.
circAssimilate
pushed a commit
to optimizely/javascript-sdk
that referenced
this pull request
Mar 4, 2020
… event (#418) ## Summary - Log a warning when an event key is not found in the datafile instead of throwing an Error - Log a warning mentioning that user tracking is not happening - Update actual error logger in catch to be an ERROR instead of INFO - Updated CONTRIBUTING.md instructions with CHANGELOG.md update instructions In a similar vein as optimizely/java-sdk#361, the JavaScript SDK noise could be more configurable for use with integrations like Segment. _Note:_ Please pardon the prettier noise. I tried to do a prep PR in #419 but there are still changes when I save. The actual functionality changes are in 646665d. ## Test plan - Updated unit test to cover new functionality - Ensure other tests pass ## Issues - [OASIS-6054](https://optimizely.atlassian.net/browse/OASIS-6054)
Closed
|
Thanks for your contribution! Can you all please sign the CLA in the CONTRIBUTING.MD doc if you haven't yet? Meanwhile I will get this reviewed. |
mikecdavis
approved these changes
Mar 30, 2020
I forgot to tag you guys, but @compass-vin @alanhu1996 since you both have commits in this PR, can you guys sign our CLA and I can get this merged and released asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WARNwhen experiment and event names are passed that are not in the datafile. Currently it is anERROR, however that seems to be too severe since the situation is completely recoverable. (see Design decision behind error log for Event and Experiment not in datafile #353)Test plan
WARNseverity levelIssues