feat(core)[OASIS-6054]: Change Error to LOG_LEVEL.WARNING for unfound event #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
circAssimilate
commented
Mar 3, 2020
| @@ -57,7 +57,10 @@ var DEFAULT_ONREADY_TIMEOUT = 30000; | |||
| function Optimizely(config) { | |||
| var clientEngine = config.clientEngine; | |||
| if (enums.VALID_CLIENT_ENGINES.indexOf(clientEngine) === -1) { | |||
| config.logger.log(LOG_LEVEL.INFO, jsSdkUtils.sprintf(LOG_MESSAGES.INVALID_CLIENT_ENGINE, MODULE_NAME, clientEngine)); | |||
| config.logger.log( | |||
There was a problem hiding this comment.
Most of this file's updates are Prettier changes. Here's the only updated part:
circAssimilate
commented
Mar 3, 2020
| @@ -46,11 +46,11 @@ var DECISION_SOURCES = enums.DECISION_SOURCES; | |||
| var DECISION_NOTIFICATION_TYPES = enums.DECISION_NOTIFICATION_TYPES; | |||
| var FEATURE_VARIABLE_TYPES = enums.FEATURE_VARIABLE_TYPES; | |||
|
|
|||
| describe('lib/optimizely', function() { | |||
| describe('lib/optimizely', function () { | |||
There was a problem hiding this comment.
Most of this file's updates are Prettier changes. Here's the only updated part:
1 task
circAssimilate
pushed a commit
that referenced
this pull request
Mar 3, 2020
Run prettier on files changed in #418 so it's easier to review
80b9cd6 to
0465565
Compare
added 2 commits
March 3, 2020 11:10
… event In a similar vein as optimizely/java-sdk#361, the JavaScript SDK would be less noisy when being used with integrations like Segment if we only logged a warning when an event key is not found in the datafile. This PR will make that change and unblock event tracking.
0465565 to
69ef35f
Compare
jamesopti
reviewed
Mar 3, 2020
mjc1283
suggested changes
Mar 3, 2020
69ef35f to
646665d
Compare
circAssimilate
commented
Mar 3, 2020
| @@ -46,11 +46,11 @@ var DECISION_SOURCES = enums.DECISION_SOURCES; | |||
| var DECISION_NOTIFICATION_TYPES = enums.DECISION_NOTIFICATION_TYPES; | |||
| var FEATURE_VARIABLE_TYPES = enums.FEATURE_VARIABLE_TYPES; | |||
|
|
|||
| describe('lib/optimizely', function () { | |||
| describe('lib/optimizely', function() { | |||
There was a problem hiding this comment.
Most of this file's updates are Prettier changes. Here's the only updated part:
mjc1283
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
@circAssimilate LGTM. One last thing, could you please add an entry to CHANGELOG.md for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a similar vein as optimizely/java-sdk#361, the JavaScript SDK noise could be more configurable for use with integrations like Segment.
Note: Please pardon the prettier noise. I tried to do a prep PR in #419 but there are still changes when I save. The actual functionality changes are in 646665d.
Test plan
Issues