8000 refactor(core): Prettier prep for PR 418 by circAssimilate · Pull Request #419 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

refactor(core): Prettier prep for PR 418 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

refactor(core): Prettier prep for PR 418 #419

merged 1 commit into from
Mar 3, 2020

Conversation

circAssimilate
Copy link
Contributor
@circAssimilate circAssimilate commented Mar 3, 2020 •
edited
Loading

Summary

Test plan

  • Ensure tests pass

@circAssimilate circAssimilate requested a review from a team as a code owner March 3, 2020 16:44
@circAssimilate circAssimilate mentioned this pull request Mar 3, 2020
Merged
@circAssimilate circAssimilate removed their assignment Mar 3, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.331% when pulling 00d74c0 on derek/418/prettier_prep into fb7b674 on master.

@circAssimilate circAssimilate merged commit a04a74a into master Mar 3, 2020
@circAssimilate circAssimilate deleted the derek/418/prettier_prep branch March 3, 2020 17:03
circAssimilate pushed a commit that referenced this pull request Mar 4, 2020
feat(core)[OASIS-6054]: Change Error to LOG_LEVEL.WARNING for unfound…
6e00881 
… event (#418)

## Summary
- Log a warning when an event key is not found in the datafile instead of throwing an Error
- Log a warning mentioning that user tracking is not happening
- Update actual error logger in catch to be an ERROR instead of INFO
- Updated CONTRIBUTING.md instructions with CHANGELOG.md update instructions

In a similar vein as optimizely/java-sdk#361, the JavaScript SDK noise could be more configurable for use with integrations like Segment.

_Note:_ Please pardon the prettier noise. I tried to do a prep PR in #419 but there are still changes when I save. The actual functionality changes are in 646665d.

## Test plan
- Updated unit test to cover new functionality
- Ensure other tests pass

## Issues
- [OASIS-6054](https://optimizely.atlassian.net/browse/OASIS-6054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@circAssimilate @coveralls @mjc1283
0