8000 (fix) change log level to warn when experiment not in datafile (#361) · optimizely/java-sdk@97ad2eb · GitHub
[go: up one dir, main page]
Skip to content

Commit 97ad2eb

Browse files
compass-vincompass-vin
authored
(fix) change log level to warn when experiment not in datafile (#361)
1 parent 568f9ed commit 97ad2eb

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

‎core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ public Experiment getExperimentForKey(@Nonnull String experimentKey,
221221
// if the given experiment key isn't present in the config, log an exception to the error handler
222222
if (experiment == null) {
223223
String unknownExperimentError = String.format("Experiment \"%s\" is not in the datafile.", experimentKey);
224-
logger.error(unknownExperimentError);
224+
logger.warn(unknownExperimentError);
225225
errorHandler.handleError(new UnknownExperimentException(unknownExperimentError));
226226
}
227227

@@ -247,7 +247,7 @@ public EventType getEventTypeForName(String eventName, ErrorHandler errorHandler
247247
// if the given event name isn't present in the config, log an exception to the error handler
248248
if (eventType == null) {
249249
String unknownEventTypeError = String.format("Event \"%s\" is not in the datafile.", eventName);
250-
logger.error(unknownEventTypeError);
250+
logger.warn(unknownEventTypeError);
251251
errorHandler.handleError(new UnknownEventTypeException(unknownEventTypeError));
252252
}
253253

‎core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ public void activateWithUnknownExperimentKeyAndNoOpErrorHandler() throws Excepti
531531
Experiment unknownExperiment = createUnknownExperiment();
532532
Optimizely optimizely = optimizelyBuilder.withErrorHandler(new NoOpErrorHandler()).build();
533533

534-
logbackVerifier.expectMessage(Level.ERROR, "Experiment \"unknown_experiment\" is not in the datafile.");
534+
logbackVerifier.expectMessage(Level.WARN, "Experiment \"unknown_experiment\" is not in the datafile.");
535535
logbackVerifier.expectMessage(Level.INFO,
536536
"Not activating user \"userId\" for experiment \"unknown_experiment\".");
537537

@@ -986,7 +986,7 @@ public void trackEventWithUnknownEventKeyAndNoOpErrorHandler() throws Exception
986986

987987
Optimizely optimizely = optimizelyBuilder.withErrorHandler(new NoOpErrorHandler()).build();
988988

989-
logbackVerifier.expectMessage(Level.ERROR, "Event \"unknown_event_type\" is not in the datafile.");
989+
logbackVerifier.expectMessage(Level.WARN, "Event \"unknown_event_type\" is not in the datafile.");
990990
logbackVerifier.expectMessage(Level.INFO, "Not tracking event \"unknown_event_type\" for user \"userId\".");
991991
optimizely.track(unknownEventType.getKey(), testUserId);
992992
}
@@ -1333,7 +1333,7 @@ public void getVariationWithUnknownExperimentKeyAndNoOpErrorHandler() throws Exc
13331333
.withErrorHandler(new NoOpErrorHandler())
13341334
.build();
13351335

1336-
logbackVerifier.expectMessage(Level.ERROR, "Experiment \"unknown_experiment\" is not in the datafile.");
1336+
logbackVerifier.expectMessage(Level.WARN, "Experiment \"unknown_experiment\" is not in the datafile.");
13371337

13381338
// since we use a NoOpErrorHandler, we should fail and return null
13391339
Variation actualVariation = optimizely.getVariation(unknownExperiment.getKey(), testUserId);

0 commit comments

Comments
 (0)
0