8000 Timing issue with Activate() & Track() being called sequentially while not able to await on the async method calls by mfahadahmed · Pull Request #54 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]
Skip to content

Timing issue with Activate() & Track() being called sequentially while not able to await on the async method calls #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2018
Merged

Timing issue with Activate() & Track() being called sequentially while not able to await on the async method calls #54

merged 1 commit into from
Jan 22, 2018

Conversation

mfahadahmed
Copy link
Contributor

No description provided.

@mfahadahmed
Eventdispatcherissue (#35)
fdaad27 
Fixed Timing issue with Activate() & Track() being called sequentially
@optibot
Copy link
Contributor
optibot commented Jan 18, 2018
10000

Can one of the admins verify this patch?

1 similar comment
@optibot
Copy link
Contributor
optibot commented Jan 18, 2018

Can one of the admins verify this patch?

@HistoricallyCorrect HistoricallyCorrect mentioned this pull request Jan 22, 2018
Closed
@kellyroach-optimizely
Copy link
Contributor

TEST:

  • 178/178 unit tests PASSED
  • E2E PASSED
  • DemoApp PASSED

@kellyroach-optimizely
Copy link
Contributor

CODE REVIEW

The competing P.R. #52 and P.R. #53 which now propose identical code changes
have been considered. We think P.R. #54 is the best proposal and it is being APPROVED.

@kellyroach-optimizely kellyroach-optimizely merged commit 5df7cfb into optimizely:master Jan 22, 2018
This was referenced Jan 23, 2018
Closed
Closed
mfahadahmed added a commit to msohailhussain/csharp-sdk that referenced this pull request Feb 9, 2018
@mfahadahmed
Reverted PR optimizely#54 of optimizely-master branch to make the Act…
e83cb64 
…ivate() API asynchronous.
@mfahadahmed mfahadahmed mentioned this pull request Feb 9, 2018
Closed
@mfahadahmed mfahadahmed deleted the event_dispatcher_issue branch March 6, 2018 13:59
kellyroach-optimizely added a commit that referenced this pull request Mar 29, 2018
@kellyroach-optimizely
Revert "Eventdispatcherissue (#35) (#54)"
bdaa7be 
This reverts commit 5df7cfb.
kellyroach-optimizely added a commit that referenced this pull request Apr 3, 2018
@kellyroach-optimizely
OASIS-2504 [C#] Release 2.0.0-beta1 (#71)
b62fc68 
* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1
kellyroach-optimizely added a commit that referenced this pull request Apr 3, 2018
@kellyroach-optimizely
OASIS-2504 [C#] Release 2.0.0-beta1 (#71)
617feed 
* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1
@kellyroach-optimizely kellyroach-optimizely mentioned this pull request Apr 3, 2018
Merged
kellyroach-optimizely added a commit that referenced this pull request Apr 6, 2018
@kellyroach-optimizely
OASIS-2504 [C#] Release 2.0.0-beta1 (#72)
0fff35b 
* OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

* Correct 2.0.0-beta1 release date in CHANGELOG.md
kellyroach-optimizely added a commit that referenced this pull request Jun 20, 2018
@kellyroach-optimizely
2.0.1 (#86)
caa791c 
* GetEnabledFeatures now returns sorted features list. (#69)

* GetEnabledFeatures now returns sorted features list ignoring case

* Removes sorting from GetEnabledFeatures method. (#73)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#72)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

* Correct 2.0.0-beta1 release date in CHANGELOG.md

* 2.0.0-beta1 --> 2.0.0 (#74) (#75)

* Input validation in Activate, Track and GetVariation methods. (#76)

* Input validation in Activate, Track and GetVariation methods.

* Replaced InputType enum with string constants.

* Updates unit tests.

* Fix impression sent from feature experiment variation toggled off.

* Revert "Fix impression sent from feature experiment variation toggled off."

This reverts commit c943747.

* Fix impression sent from feature experiment variation toggled off. (#84)

* Update OptimizelySDK.DemoApp.csproj OptimizelySDK Reference

* Update AssemblyVersion, AssemblyFileVersion, AssemblyInformationalVersion

* Update the OptimizelySDK.Package/OptimizelySDK.nuspec

* Upgrade DemoApp to OptimizelySDK 2.0.1
kellyroach-optimizely added a commit that referenced this pull request Jun 21, 2018
@kellyroach-optimizely
2.0.1 (#86)
dce781c 
* GetEnabledFeatures now returns sorted features list. (#69)

* GetEnabledFeatures now returns sorted features list ignoring case

* Removes sorting from GetEnabledFeatures method. (#73)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#72)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

* Correct 2.0.0-beta1 release date in CHANGELOG.md

* 2.0.0-beta1 --> 2.0.0 (#74) (#75)

* Input validation in Activate, Track and GetVariation methods. (#76)

* Input validation in Activate, Track and GetVariation methods.

* Replaced InputType enum with string constants.

* Updates unit tests.

* Fix impression sent from feature experiment variation toggled off.

* Revert "Fix impression sent from feature experiment variation toggled off."

This reverts commit c943747.

* Fix impression sent from feature experiment variation toggled off. (#84)

* Update OptimizelySDK.DemoApp.csproj OptimizelySDK Reference

* Update AssemblyVersion, AssemblyFileVersion, AssemblyInformationalVersion

* Update the OptimizelySDK.Package/OptimizelySDK.nuspec

* Upgrade DemoApp to OptimizelySDK 2.0.1
kellyroach-optimizely added a commit that referenced this pull request Jun 21, 2018
@kellyroach-optimizely
Kroach/oasis 3134 release master (#87)
da13545 
* 2.0.1 (#86)

* GetEnabledFeatures now returns sorted features list. (#69)

* GetEnabledFeatures now returns sorted features list ignoring case

* Removes sorting from GetEnabledFeatures method. (#73)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#72)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

* Correct 2.0.0-beta1 release date in CHANGELOG.md

* 2.0.0-beta1 --> 2.0.0 (#74) (#75)

* Input validation in Activate, Track and GetVariation methods. (#76)

* Input validation in Activate, Track and GetVariation methods.

* Replaced InputType enum with string constants.

* Updates unit tests.

* Fix impression sent from feature experiment variation toggled off.

* Revert "Fix impression sent from feature experiment variation toggled off."

This reverts commit c943747.

* Fix impression sent from feature experiment variation toggled off. (#84)

* Update OptimizelySDK.DemoApp.csproj OptimizelySDK Reference

* Update AssemblyVersion, AssemblyFileVersion, AssemblyInformationalVersion

* Update the OptimizelySDK.Package/OptimizelySDK.nuspec

* Upgrade DemoApp to OptimizelySDK 2.0.1

* Update verifysn.ps1 to 2.0.1

* Update CHANGELOG.md to OptimizelySDK 2.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyroach-optimizely kellyroach-optimizely Awaiting requested review from kellyroach-optimizely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfahadahmed @optibot @kellyroach-optimizely
0