DispatchEvent() must be sequential and cannot be fire & forget #52
Conversation
When Activate() & Track() are called, Track() can only proceed after Activate() completes successfully. Hence the fire & forget pattern for DispatchEvent() will not work.
|
Can one of the admins verify this patch? |
| { | ||
| Task.Run(() => DispatchEventAsync(logEvent)); | ||
| } | ||
|
|
There was a problem hiding this comment.
The prime effect of the P.R. #52 proposal will be to change the body of DispatchEvent .
However, I don't understand the purpose of keeping DispatchEventSilently around.
The SDK code doesn't call it and HttpClientEventDispatcher45 isn't documented in
Optimizely's developer documentation. Isn't DispatchEventSilently dead code? Why
isn't this deleted?
There was a problem hiding this comment.
Because I was not sure whether there was a legit reason behind DispatchEvent hiding asynchronous nature of DispatchEventAsync. So I left and renamed the old code as DispatchEventSilently thinking maybe you want to preserve a async version of DispatchEvent and name it more obviously. But if there is no strong reason behind it, then I agree DispatchEventSilently is dead code and should be removed.
|
SUPERCEDED BY APPROVED P.R. #54 |
When Activate() & Track() are called, Track() can only proceed after
Activate() completes successfully. Hence the fire & forget pattern for
DispatchEvent() will not work.
Original issue:
#51