8000 Kroach/oasis 2169 issue by kellyroach-optimizely · Pull Request #53 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]

Skip to content

Kroach/oasis 2169 issue #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for Gi 8000 tHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kellyroach-optimizely
Copy link
Contributor
@kellyroach-optimizely kellyroach-optimizely commented Jan 16, 2018

OASIS-2169 [C#] Timing issue with Activate() & Track()

This P.R. is proposed to resolve csharp-sdk issue #51

Unlike P.R. #52, it does not include the dead code DispatchEventSilently .

TEST:

  • Unit tests, 178/178 PASSED
  • E2E PASSED as well as expected

HC and others added 2 commits January 9, 2018 14:44
When Activate() & Track() are called, Track() can only proceed after
Activate() completes successfully. Hence the fire & forget pattern for
DispatchEvent() will not work.
@kellyroach-optimizely
Copy link
Contributor Author

SUPERCEDED BY APPROVED P.R. #54

@aliabbasrizvi aliabbasrizvi deleted the kroach/OASIS-2169-issue branch June 27, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0