8000 OASIS-2504 [C#] Release 2.0.0-beta1 by kellyroach-optimizely · Pull Request #72 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]
Skip to content

OASIS-2504 [C#] Release 2.0.0-beta1 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2018
Merged

OASIS-2504 [C#] Release 2.0.0-beta1 #72

merged 2 commits into from
Apr 6, 2018

Conversation

kellyroach-optimizely
Copy link
Contributor
@kellyroach-optimizely kellyroach-optimizely commented Apr 3, 2018 •
edited
Loading

This pull request amounts to merging into master branch the same 2.0.0-beta1 changes which were just merged into 2.0.x branch via P.R. #71 . We cherry-pick'ed the P.R. #71 commit into this branch ("kroach/OASIS-2540-release") and propose to merge this branch into master branch. The goal is to get master branch caught up with changes which were released in 2.0.0-beta1 (The changes are listed below, but we mention here: version numbers, *.nuspec, revised 1.3.1 DemoApp, CHANGELOG.md, other files updated during 2.0.0-beta1 release.)

OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

This reverts commit 5df7cfb.

  • Bump version to 2.0 beta.

  • Update OptimizelySDK.nuspec

  • AssemblyVersion = 2.0.0.0

  • Improved 1.3.1 DemoApp

  • Updated OptimizelySDK.Package and OptimizelySDK.nuspec

  • keypair.snk for *.sln, *.csproj

  • CHANGELOG.md corrections

  • SDK_VERSION synch with NuGet package version.

  • Make 'UserAttributes userAttributes = null' optional in 5 API's

  • Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

@kellyroach-optimizely
OASIS-2504 [C#] Release 2.0.0-beta1 (#71)
617feed 
* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1
mikeproeng37
mikeproeng37 reviewed Apr 5, 2018
View reviewed changes
CHANGELOG.md Outdated
@@ -1,26 +1,25 @@
## 2.0.0-beta1

March 29th, 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually went out April 2nd, or 3rd?

Copy link
Contributor Author
@kellyroach-optimizely kellyroach-optimizely Apr 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with correct date "April 3, 2018" by commit
900917f .

mikeproeng37
mikeproeng37 reviewed Apr 5, 2018
View reviewed changes
OptimizelySDK/Optimizely.cs
String answer = String.Format("{0}.{1}.{2}", version.Major, version.Minor, version.Build);
return answer;
// Should be kept in synch with NuGet package version.
return "2.0.0-beta1";
Copy link
Contributor
@mikeproeng37 mikeproeng37 Apr 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for changing this? Keeping this in sync with the NuGet package version manually could be error-prone since it relies on us actually remembering to do it. Is it so that we can attach the beta1 label to it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are keeping in synch with the NuGet version this release. Unfortunately, the code which I wrote previously which I replaced here is getting the version number from MS AssemblyVersion which is (1) actually ignorant of the NuGet version in the *.nuspec and (2) doesn't support "-beta1" . We'd like to do better, but what was there wouldn't get "-beta1" to OPTIMIZELY.COM .

@mikeproeng37
Copy link
Contributor

build

mikeproeng37
mikeproeng37 approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor
@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kellyroach-optimizely kellyroach-optimizely merged commit 0fff35b into master Apr 6, 2018
kellyroach-optimizely added a commit that referenced this pull request Jun 20, 2018
@kellyroach-optimizely
2.0.1 (#86)
caa791c 
* GetEnabledFeatures now returns sorted features list. (#69)

* GetEnabledFeatures now returns sorted features list ignoring case

* Removes sorting from GetEnabledFeatures method. (#73)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#72)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

* Correct 2.0.0-beta1 release date in CHANGELOG.md

* 2.0.0-beta1 --> 2.0.0 (#74) (#75)

* Input validation in Activate, Track and GetVariation methods. (#76)

* Input validation in Activate, Track and GetVariation methods.

* Replaced InputType enum with string constants.

* Updates unit tests.

* Fix impression sent from feature experiment variation toggled off.

* Revert "Fix impression sent from feature experiment variation toggled off."

This reverts commit c943747.

* Fix impression sent from feature experiment variation toggled off. (#84)

* Update OptimizelySDK.DemoApp.csproj OptimizelySDK Reference

* Update AssemblyVersion, AssemblyFileVersion, AssemblyInformationalVersion

* Update the OptimizelySDK.Package/OptimizelySDK.nuspec

* Upgrade DemoApp to OptimizelySDK 2.0.1
kellyroach-optimizely added a commit that referenced this pull request Jun 21, 2018
@kellyroach-optimizely
2.0.1 (#86)
dce781c 
* GetEnabledFeatures now returns sorted features list. (#69)

* GetEnabledFeatures now returns sorted features list ignoring case

* Removes sorting from GetEnabledFeatures method. (#73)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#72)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

* Correct 2.0.0-beta1 release date in CHANGELOG.md

* 2.0.0-beta1 --> 2.0.0 (#74) (#75)

* Input validation in Activate, Track and GetVariation methods. (#76)

* Input validation in Activate, Track and GetVariation methods.

* Replaced InputType enum with string constants.

* Updates unit tests.

* Fix impression sent from feature experiment variation toggled off.

* Revert "Fix impression sent from feature experiment variation toggled off."

This reverts commit c943747.

* Fix impression sent from feature experiment variation toggled off. (#84)

* Update OptimizelySDK.DemoApp.csproj OptimizelySDK Reference

* Update AssemblyVersion, AssemblyFileVersion, AssemblyInformationalVersion

* Update the OptimizelySDK.Package/OptimizelySDK.nuspec

* Upgrade DemoApp to OptimizelySDK 2.0.1
kellyroach-optimizely added a commit that referenced this pull request Jun 21, 2018
@kellyroach-optimizely
Kroach/oasis 3134 release master (#87)
da13545 
* 2.0.1 (#86)

* GetEnabledFeatures now returns sorted features list. (#69)

* GetEnabledFeatures now returns sorted features list ignoring case

* Removes sorting from GetEnabledFeatures method. (#73)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#72)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

* Correct 2.0.0-beta1 release date in CHANGELOG.md

* 2.0.0-beta1 --> 2.0.0 (#74) (#75)

* Input validation in Activate, Track and GetVariation methods. (#76)

* Input validation in Activate, Track and GetVariation methods.

* Replaced InputType enum with string constants.

* Updates unit tests.

* Fix impression sent from feature experiment variation toggled off.

* Revert "Fix impression sent from feature experiment variation toggled off."

This reverts commit c943747.

* Fix impression sent from feature experiment variation toggled off. (#84)

* Update OptimizelySDK.DemoApp.csproj OptimizelySDK Reference

* Update AssemblyVersion, AssemblyFileVersion, AssemblyInformationalVersion

* Update the OptimizelySDK.Package/OptimizelySDK.nuspec

* Upgrade DemoApp to OptimizelySDK 2.0.1

* Update verifysn.ps1 to 2.0.1

* Update CHANGELOG.md to OptimizelySDK 2.0.1
@aliabbasrizvi aliabbasrizvi deleted the kroach/OASIS-2540-release branch June 27, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellyroach-optimizely @mikeproeng37
0