Master #1154
Closed
Master #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affects blob objects returned by: git_blob_lookup git_blob_lookup_prefix
It's possible that we will eventually get rid of the selfFreeing parameter, and just go by the type descriptor, but for now we are more comfortable with a smaller change.
the structs git_tree_entry, git_oid, and git_signature all represent structs which are owned by some other object. In order to simplify our memory model, we should always duplicate these 3 structs when we pull them out of libgit2. This detaches these types of structs from their owning object, such that when we delete a commit, none of the oids or signatures that we retrieved from that commit would cause bad memory access.
… a crash in some cases.
Call free on GC for object types
diff.blobToBuffer: Fix passing in Buffers instead of strings.
Switch from strdup to memcpy to faithfully copy all bytes and prevent a crash in some cases.
Correct Diff.blobToBuffer documentation.
…ssage Error message on libstdc missing.
Make Ignore.pathIsIgnored async
Add support for thread safety on async actions only
Add support for git_repository__cleanup
patch libssh2 to work with vs2015
Bump libssh2 to 1.7.0
Since we can't require it from node if it's compiled for electron, we should just assume success for now
fix up electron and nw.js docs
Don't run postbuild when we detect electron install
Compile libgit2 with GIT_SSH_MEMORY_CREDENTIALS defined to allow sshKeyMemoryNew to work. Fixes #760
Define GIT_SSH_MEMORY_CREDENTIALS for libgit2
Add "Path" to ssh variable names in tests for clarity
Revert "Use npm 2.15.11 with node 0.12" This reverts commit 9503b5c. Revert "Log npm-debug.log after failure" This reverts commit 412ce63. Remove ls attempt Ls purported npm-debug.log location and ignore npm install failure Attempt to cat npm-debug.log after install failure Log npm-debug.log after failure Use npm 2.15.11 with node 0.12
Fix CI failures on node 0.12
Fix revwalk memory leaks
Fix tree entry leaks
Fix windows exception handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.