8000 Define GIT_SSH_MEMORY_CREDENTIALS for libgit2 by alantrrs · Pull Request #949 · nodegit/nodegit · GitHub
[go: up one dir, main page]
Skip to content

Define GIT_SSH_MEMORY_CREDENTIALS for libgit2#949

Merged
maxkorp merged 2 commits intonodegit:masterfrom
alantrrs:fix-memory-creds
Sep 19, 2016
Merged

Define GIT_SSH_MEMORY_CREDENTIALS for libgit2#949
maxkorp merged 2 commits intonodegit:masterfrom
alantrrs:fix-memory-creds

Conversation

@alantrrs
Copy link
@alantrrs alantrrs commented Mar 15, 2016

Compile libgit2 with GIT_SSH_MEMORY_CREDENTIALS defined to allow
sshKeyMemoryNew to work.

Fixes #760

@alantrrs
Copy link
Author
alantrrs commented Mar 15, 2016

This is just a rebase of #763 . However it seems like tests are still failing.

@alantrrs
Copy link
Author
alantrrs commented Mar 15, 2016

Rebased again. However it looks like the version of libssh2 used here is not updated since it doesn't include libssh2_userauth_publickey_frommemory. See build

Any plans to update it?
8000

@johnhaley81
Copy link
Collaborator
johnhaley81 commented Mar 16, 2016

We could update libssh2 in a different PR.

@srajko srajko force-pushed the master branch 2 times, most recently from a78275a to 206d27d Compare April 27, 2016 21:05
@richardkazuomiller
Copy link
richardkazuomiller commented May 30, 2016

Is there any status update on this and/or updating libssh2? I'd like to use sshKeyMemoryNew. I'm not good enough at C to figure out how to contribute at all though, sorry (^^ゞ

@jamon
Copy link
jamon commented Aug 16, 2016 •
edited
Loading

This definitely works with libssh2 1.7.0. I'm happy to walk through the steps to get it working, below, but I'm not familiar enough with node-gyp and nodegit's build process to do it in a pull-request worthy way.

checkout the latest nodegit code and do the following (only tested on linux):

  • remove vendor/libssh2 entirely and commit this
  • cd vendor ; git clone -b tags/libssh2-1.7.0 https://github.com/libssh2/libssh2.git (this could be done as a submodule if you'd like)
  • cd libssh2 ; ./buildconf
  • cd ../.. ; npm install
  • sudo npm link -g
  • add "GIT_SSH_MEMORY_CREDENTIALS" to the "defines" array for libgit2 (part of this pull request shows this part)

use the globally installed nodegit from your projects

@maxkorp
Copy link
Collaborator
maxkorp commented Aug 16, 2016

@jamon which OS were you testing on though? I've got a pr here: #1071

But it dies for windows

@maxkorp
Copy link
Collaborator
maxkorp commented Sep 15, 2016

Up to date! @alantrrs care to rebase on top of master?

@daxelrod @alantrrs
Define GIT_SSH_MEMORY_CREDENTIALS for libgit2
f61f52e 
Compile libgit2 with GIT_SSH_MEMORY_CREDENTIALS defined to allow
sshKeyMemoryNew to work.

Fixes nodegit#760
@alantrrs
Copy link
Author
alantrrs commented Sep 15, 2016

rebased

@maxkorp
Copy link
Collaborator
maxkorp commented Sep 19, 2016

Nice, TY

@maxkorp maxkorp merged commit ef34d8a into nodegit:master Sep 19, 2016
@maxkorp maxkorp mentioned this pull request Sep 19, 2016
Closed
@kid
Copy link
kid commented Oct 14, 2016

Any changes to see this in a new release soon?
I'm trying to install from master but I'm facing other issues

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alantrrs @johnhaley81 @richardkazuomiller @jamon @maxkorp @kid @daxelrod
0